[Wikidata-bugs] [Maniphest] [Commented On] T159828: Use redis-based lock manager for dispatchChanges on test.wikidata.org

Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2017-04-12T13:08:30Z] Synchronized wmf-config/InitialiseSettings.php: Revert "Temporarily enable change dispatch logging on testwikidata" - T159828 (duration: 00m 47s)TASK

[Wikidata-bugs] [Maniphest] [Commented On] T159828: Use redis-based lock manager for dispatchChanges on test.wikidata.org

gerritbot added a comment. Change 346788 merged by jenkins-bot: [operations/mediawiki-config@master] Revert "Temporarily enable change dispatch logging on testwikidata" https://gerrit.wikimedia.org/r/346788TASK DETAILhttps://phabricator.wikimedia.org/T159828EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T159828: Use redis-based lock manager for dispatchChanges on test.wikidata.org

gerritbot added a comment. Change 346788 had a related patch set uploaded (by Hashar; owner: Hoo man): [operations/mediawiki-config@master] Revert "Temporarily enable change dispatch logging on testwikidata" https://gerrit.wikimedia.org/r/346788TASK

[Wikidata-bugs] [Maniphest] [Commented On] T159828: Use redis-based lock manager for dispatchChanges on test.wikidata.org

hoo added a comment. In T159828#3163156, @daniel wrote: In T159828#3163026, @hoo wrote: We can set a timeout for this LockManager::lock allows that (as third argument). I don't know what would be decent here, maybe 2 or 3 minutes? The timeout must be longer than the maximum time that the lock

[Wikidata-bugs] [Maniphest] [Commented On] T159828: Use redis-based lock manager for dispatchChanges on test.wikidata.org

daniel added a comment. In T159828#3163026, @hoo wrote: We can set a timeout for this LockManager::lock allows that (as third argument). I don't know what would be decent here, maybe 2 or 3 minutes? The timeout must be longer than the maximum time that the lock could be legitimately held.

[Wikidata-bugs] [Maniphest] [Commented On] T159828: Use redis-based lock manager for dispatchChanges on test.wikidata.org

hoo added a comment. In T159828#3163025, @daniel wrote: Thank you @hoo! One thing that still worries me is that we don't have a mechanism for stale locks. If a dispatcher dies while holding a lock, that lock will stay until it times out (after 30 minutes, I think). So no changes will be

[Wikidata-bugs] [Maniphest] [Commented On] T159828: Use redis-based lock manager for dispatchChanges on test.wikidata.org

daniel added a comment. Thank you @hoo! One thing that still worries me is that we don't have a mechanism for stale locks. If a dispatcher dies while holding a lock, that lock will stay until it times out (after 30 minutes, I think). So no changes will be dispatched to the respective client

[Wikidata-bugs] [Maniphest] [Commented On] T159828: Use redis-based lock manager for dispatchChanges on test.wikidata.org

Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2017-04-06T16:17:19Z] Synchronized wmf-config/Wikibase-production.php: Try using redisLockManager for test.wikidata.org (T159828) (duration: 00m 39s)TASK DETAILhttps://phabricator.wikimedia.org/T159828EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T159828: Use redis-based lock manager for dispatchChanges on test.wikidata.org

gerritbot added a comment. Change 345387 merged by jenkins-bot: [operations/mediawiki-config@master] Try using redisLockManager for test.wikidata.org https://gerrit.wikimedia.org/r/345387TASK DETAILhttps://phabricator.wikimedia.org/T159828EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T159828: Use redis-based lock manager for dispatchChanges on test.wikidata.org

gerritbot added a comment. Change 346540 merged by jenkins-bot: [operations/mediawiki-config@master] Temporarily enable change dispatch logging on testwikidata https://gerrit.wikimedia.org/r/346540TASK DETAILhttps://phabricator.wikimedia.org/T159828EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T159828: Use redis-based lock manager for dispatchChanges on test.wikidata.org

gerritbot added a comment. Change 346545 merged by Jcrespo: [operations/puppet@production] Temporarily disable the change dispatch cron for testwikidata https://gerrit.wikimedia.org/r/346545TASK DETAILhttps://phabricator.wikimedia.org/T159828EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T159828: Use redis-based lock manager for dispatchChanges on test.wikidata.org

gerritbot added a comment. Change 346545 had a related patch set uploaded (by Hoo man): [operations/puppet@production] Temporarily disable the change dispatch cron for testwikidata https://gerrit.wikimedia.org/r/346545TASK DETAILhttps://phabricator.wikimedia.org/T159828EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T159828: Use redis-based lock manager for dispatchChanges on test.wikidata.org

gerritbot added a comment. Change 346540 had a related patch set uploaded (by Hoo man): [operations/mediawiki-config@master] Temporarily enable change dispatch logging on testwikidata https://gerrit.wikimedia.org/r/346540TASK DETAILhttps://phabricator.wikimedia.org/T159828EMAIL