gerritbot added a comment.
Change 347381 abandoned by Hashar:
(Do not submit) unregister qunit tests
Reason:
Got fixed :-}
https://gerrit.wikimedia.org/r/347381TASK DETAILhttps://phabricator.wikimedia.org/T161287EMAIL
gerritbot added a comment.
Change 347354 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Fix broken QUnit tests.
https://gerrit.wikimedia.org/r/347354TASK DETAILhttps://phabricator.wikimedia.org/T161287EMAIL
hashar added a comment.
Looks like a test did $.ajax = function () {}. I hate scoping issue, congratulations on figuring out that one! -;-)
The CI change is deployed so the QUnit job should trigger from now on.TASK DETAILhttps://phabricator.wikimedia.org/T161287EMAIL
gerritbot added a comment.
Change 347596 merged by jenkins-bot:
[integration/config@master] Enable QUnit tests for WikibaseLexeme
https://gerrit.wikimedia.org/r/347596TASK DETAILhttps://phabricator.wikimedia.org/T161287EMAIL
Jakob_WMDE added a comment.
They were failing due to some silly test overriding jQuery.ajax. Should be working now. Thanks for looking into it, @hashar!TASK DETAILhttps://phabricator.wikimedia.org/T161287EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
gerritbot added a comment.
Change 347596 had a related patch set uploaded (by Jakob):
[integration/config@master] Enable QUnit tests for WikibaseLexeme
https://gerrit.wikimedia.org/r/347596TASK DETAILhttps://phabricator.wikimedia.org/T161287EMAIL
gerritbot added a comment.
Change 347354 had a related patch set uploaded (by Jakob):
[mediawiki/extensions/WikibaseLexeme@master] Fix broken QUnit tests.
https://gerrit.wikimedia.org/r/347354TASK DETAILhttps://phabricator.wikimedia.org/T161287EMAIL
hashar added a comment.
What is puzzling is Jonas told me that they pass fine locally. Maybe that is a bad interaction with one of the other extension. I will try tomorrow by cloning all of them and see and what happens. The list being:
mediawiki/extensions/WikibaseLexeme
hashar added a comment.
https://gerrit.wikimedia.org/r/#/c/347381/1 is a dummy change for WikibaseLexeme that unregister all qunit tests for that extension. The Qunit job passes.
https://gerrit.wikimedia.org/r/#/c/347381/2 I removed the scripts but kept the dependencies (who knows). And it
gerritbot added a comment.
Change 347381 had a related patch set uploaded (by Hashar):
[mediawiki/extensions/WikibaseLexeme@master] (Do not submit) unregister qunit tests
https://gerrit.wikimedia.org/r/347381TASK DETAILhttps://phabricator.wikimedia.org/T161287EMAIL
hashar added a comment.
On both builds there is a time out being reached and the build abort after 60 seconds:
build 5910
00:06:45.981 Chrome 57.0.2987 (Linux 0.0.0): Executed 705 of 1441 (6 FAILED) (0 secs / 1 min 6.224 secs)
00:07:46.005 24 03 2017 07:17:49.848:WARN [Chrome 57.0.2987 (Linux
11 matches
Mail list logo
