daniel added a comment.
@Ladsgroup I have an alternative proposal. Here's how I understand the need:
we want a file defining templates for WikibaseRepo, and a factory service for getting these templates in PHP
we want a file defining templates for WikibaseLexeme, and a factory service for getting
thiemowmde added a comment.
This sound like an incredible amount of overhead for a thing that can't be much more trivial: templates are basically nothing but an array of strings. We only need something like this (preferably not as complicated as outlined above) if LexemeView needs access to Wikibas
gerritbot added a comment.
Change 345514 abandoned by Ladsgroup:
Change $instance attribute visiblity in Template factory to protected
https://gerrit.wikimedia.org/r/345514TASK DETAILhttps://phabricator.wikimedia.org/T161789EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpre
daniel added a comment.
@thiemowmde you seem to be misunderstanding my suggestion. It boils down to literally just new TemplateFactory( '.lexeme-templates.php' );. That instances needs to be accessible somehow, so you need a "singleton" (really, a default instance). Can be a static member, but
gerritbot added a comment.
Change 345515 merged by Jonas Kress (WMDE):
[mediawiki/extensions/WikibaseLexeme@master] Introduce LexemeTemplateFactory and templates.php file
https://gerrit.wikimedia.org/r/345515TASK DETAILhttps://phabricator.wikimedia.org/T161789EMAIL PREFERENCEShttps://phabricator.w
gerritbot added a comment.
Change 347337 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Remove subclassing and unused code from LexemeTemplateFactory
https://gerrit.wikimedia.org/r/347337TASK DETAILhttps://phabricator.wikimedia.org/T161789E
gerritbot added a comment.
Change 347337 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Remove subclassing and unused code from LexemeTemplateFactory
https://gerrit.wikimedia.org/r/347337TASK DETAILhttps://phabricator.wikimedia.org/T161789EMAIL PREFERENCEShttps://phabricator.w
