Smalyshev added a comment.
Note that while I add the patches, I can't close github pulls. This is probably the state of affairs for most other repos too, since most of the devs aren't github owners.TASK DETAILhttps://phabricator.wikimedia.org/T164700EMAIL
Izno added a comment.
I have already pointed to the general task for dealing with this issue.
If you are interested in further discussion, please take it over there to centralize.TASK DETAILhttps://phabricator.wikimedia.org/T164700EMAIL
Yurik added a comment.
@Aklapper I meant that a phab ticket is a much more convenient way to manage reminders and organize/plan/track work. The review of the code should happen in the code itself, which in this case is actually github (it has an excellent review system).
It is still not ideal,
Aklapper added a comment.
In T164700#3245080, @Yurik wrote:
auto-creating phab tickets based on pull requests should solve it
That makes no sense. Pull requests are code. Code Review happens in Gerrit, not in a Phab Maniphest ticket.TASK DETAILhttps://phabricator.wikimedia.org/T164700EMAIL
Smalyshev added a comment.
The right way would be to have single place - e.g. have these duplicated in Gerrit. Not sure how hard it is to do. Watching two places is not usually going to work well.TASK DETAILhttps://phabricator.wikimedia.org/T164700EMAIL
