gerritbot added a comment.
Change 403310 merged by jenkins-bot:
[wikidata/query/rdf@master] Use built GUI for distribution package
https://gerrit.wikimedia.org/r/403310TASK DETAILhttps://phabricator.wikimedia.org/T166246EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailprefere
Gehel added a comment.
Mixing maven and npm projects from 2 different repositories in the same source tree by using git submodules is somewhat ugly, and we can't seem to agree on the right way to do it. So a different idea:
Could we / should we use more standard composition mechanism and treat the
gerritbot added a comment.
Change 403310 had a related patch set uploaded (by Gehel; owner: Smalyshev):
[wikidata/query/rdf@master] Use built GUI for distribution package
https://gerrit.wikimedia.org/r/403310TASK DETAILhttps://phabricator.wikimedia.org/T166246EMAIL PREFERENCEShttps://phabricator.w
gerritbot added a comment.
Change 403310 had a related patch set uploaded (by Smalyshev; owner: Smalyshev):
[wikidata/query/rdf@master] Use built GUI for distribution package
https://gerrit.wikimedia.org/r/403310TASK DETAILhttps://phabricator.wikimedia.org/T166246EMAIL PREFERENCEShttps://phabricat
Smalyshev added a comment.
Since we need nginx anyway, I think serving it via nginx is fine. But it'd be definitely good to make it build properly.TASK DETAILhttps://phabricator.wikimedia.org/T166246EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc:
Gehel added a comment.
As far as I can see, at the moment, the Maven build only adds the gui files to the package, without any build step. We could probably move the gui to a maven module and use the frontend-maven-plugin to execute the build steps required. And add the resulting artifact to the pa
