cscott added a comment.
@thiemowmde Nevermind, I got a little mixed up. I was concerned that -{zh:Foo;zh-tw:Bar}- would add an entry to the global translation table, in addition to specifying a one-time conversion. But that's not the case. You need to add the A or H (or -) flag to have global ef
thiemowmde added a comment.
@cscott, I'm afraid I don't understand. Is your comment a response to something specific that was said before? Do you think there is something we can improve, in addition to what https://gerrit.wikimedia.org/r/356801 already did? What "nonlocal" effects do you mean?TASK
cscott added a comment.
Hm, doesn't think -{...}- markup have side effects (ie, adding a rule to the conversion table) if the codes involved are languages, not scripts? Seems like you ought to be a little careful, since the "escape" function being used can have nonlocal effects.TASK DETAILhttps://
gerritbot added a comment.
Change 356801 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Optimize VariantsAwareRenderer to not output broken weblink syntax
https://gerrit.wikimedia.org/r/356801TASK DETAILhttps://phabricator.wikimedia.org/T166429EMAIL PREFERENCEShttps://phabricator.wi
ssastry added a comment.
In T166429#3309853, @Cwek wrote:
@thiemowmde
I think the second solution is maybe better. And I think that we can check the data type of property to confirm whether it is URL or not. If the date type of property is URL and the site have enabled Language Converter, the o
cscott added a comment.
This is not related to the preprocessor change, it is long-standing bug in php LanguageConverter (to wit, conversion is applied at an awkward point in the parser pipeline, so it doesn't properly respect other syntactic structures). Sadly, LanguageConverter is riddled with t
ssastry added a comment.
In T166429#3312548, @Elitre wrote:
@ssastry was this tied to the recent preprocessor change? Thanks.
The preprocessor change was deployed to these group2 wikis on June 1 and the bug report and other discussion is from before that. So, that indicates this is unrelated to
gerritbot added a comment.
Change 356801 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/Wikibase@master] Optimize VariantsAwareRenderer to not output broken weblink syntax
https://gerrit.wikimedia.org/r/356801TASK DETAILhttps://phabri
Cwek added a comment.
@thiemowmde
I think the second solution is maybe better. And I think that we can check the data type of property to confirm whether it is URL or not. If the date type of property is URL and the site have enabled Language Converter, the output does not format with variant code