Etonkovidova added a comment.
Checked the fix in production (wmf.12). Wikidata (and log entries) do not display ORES highlighting for the new filters and for the old ORES based highlighting.TASK DETAILhttps://phabricator.wikimedia.org/T168487EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settin
gerritbot added a comment.
Change 368117 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Follow-up a93bd12: also ignore RC_LOG/RC_EXTERNAL in non-RCFilters UI
https://gerrit.wikimedia.org/r/368117TASK DETAILhttps://phabricator.wikimedia.org/T168487EMAIL PREFERENCEShttps://phabricator.wik
Catrope added a comment.
In T168487#3474933, @SBisson wrote:
From the task description:
There should be no highlighting for these rows regardless of whether it's using the original ORES highlighting or the newer highlighting done by RC Page itself.
Note that the patch above doesn't handle the or
SBisson added a comment.
From the task description:
There should be no highlighting for these rows regardless of whether it's using the original ORES highlighting or the newer highlighting done by RC Page itself.
Note that the patch above doesn't handle the original ORES highlighting.
Also, not
gerritbot added a comment.
Change 367841 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Treat RC_LOG and RC_EXTERNAL rows as unscorable
https://gerrit.wikimedia.org/r/367841TASK DETAILhttps://phabricator.wikimedia.org/T168487EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/pa
Catrope added a comment.
In T168487#3473450, @gerritbot wrote:
Change 367841 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/ORES@master] Treat RC_LOG and RC_EXTERNAL rows as unscorable
https://gerrit.wikimedia.org/r/367841
This patch does the following:
gerritbot added a comment.
Change 367841 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/extensions/ORES@master] Treat RC_LOG and RC_EXTERNAL rows as unscorable
https://gerrit.wikimedia.org/r/367841TASK DETAILhttps://phabricator.wikimedia.org/T168487EMAIL PREFERENCEShttps
Catrope added a comment.
In T168487#3391019, @Halfak wrote:
Is this something that the ORES Review Tool is doing? I'm confused.
Both the ORT and RCFilters do this. As I understand it, the culprit is that recentchanges rows that come from Wikidata have an rc_this_oldid that refers to a revision
Halfak added a comment.
Is this something that the ORES Review Tool is doing? I'm confused.TASK DETAILhttps://phabricator.wikimedia.org/T168487EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: HalfakCc: Halfak, Aklapper, Mattflaschen-WMF, bkowshik, GoranSMilova
