Johnuniq added a comment.
Any comments about my guess in the initial report? I speculated that php.getEntityId in mw.wikibase.lua sometimes returns junk due to a timeout when it tries to establish a network connection with the Wikidata database (that I know nothing about).
On the other hand, I saw
ValterVB added a comment.
@daniel I used a null edit via bot and this solution work. The problem is that the number of pages with error is increasing steadily, just now we have 1859 page but the number increase, based on my little statistic, I checked only 120 pages, more or less has the problem wi
Jarekt added a comment.
In T170039#3444648, @daniel wrote:
Yea, but what does "fail" mean, exactly? I guess I could just try it out, but I'm lazy with Lua. I'll check tomorrow.
You will get a big red Error "Lua error in at line ...". We did not observed that. My guess is that data is not nu
Vachovec1 added a comment.
The error can be persistent (if the affected page is not purged). I am watching this page: https://cs.wikipedia.org/wiki/Ole%C5%A1nice_(Polsko) for several days and the error is still present (not purging as it can be useful for debugging).
Another thing: it looks like a
daniel added a comment.
In T170039#3444564, @matej_suchanek wrote:
if data == nil, data.schemaVersion itself will fail, just like -> accessing undeclared property in PHP. Type check won't take place.
Yea, but what does "fail" mean, exactly? I guess I could just try it out, but I'm lazy with Lua.
Jarekt added a comment.
and if data.schemaVersion == nil than type( data.schemaVersion ) will return string "nil" and trigger the error we see.TASK DETAILhttps://phabricator.wikimedia.org/T170039EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JarektCc: daniel,
matej_suchanek added a comment.
if data == nil, data.schemaVersion itself will fail, just like -> accessing undeclared property in PHP. Type check won't take place.TASK DETAILhttps://phabricator.wikimedia.org/T170039EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/
Jarekt added a comment.
https://www.mediawiki.org/wiki/Extension:Scribunto/Lua_reference_manual#type does not say so I will check.TASK DETAILhttps://phabricator.wikimedia.org/T170039EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JarektCc: daniel, putnik, Fram
daniel added a comment.
@Jarekt thanks. I have one concern: what does type( data.schemaVersion ) do if data is nil?TASK DETAILhttps://phabricator.wikimedia.org/T170039EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: daniel, putnik, Framawiki, Zebulon8
daniel added a comment.
The bad data seems to be coming in via mw.wikibase.getEntityObject(). mw.clone() is a candidate for returning bad data. Or bad data gets into the local cache somehow.
But I can't think of a reason for this to happen "sometimes"TASK DETAILhttps://phabricator.wikimedia.or
Jarekt added a comment.
Maybe:
if type( data ) ~= 'table' or type( data.schemaVersion ) ~= 'number' then
local errStr = string.format('The entity data must be a table obtained via mw.wikibase.getEntityObject ( data type = %s; schema version type = %s)', type( data ), type( data.schemaVersion ))
daniel added a comment.
The code that triggers the error is a simple guard against type and version errors:
if type( data ) ~= 'table' or type( data.schemaVersion ) ~= 'number' then
error( 'The entity data must be a table obtained via mw.wikibase.getEntityObject' )
end
We could perhaps gai
daniel added a comment.
The only thing I can think of right now is to write a script to purge and check a page in a loop, trying to trigger the error by parsing the page over and over. If this doesn't do it, I have no idea where to look.TASK DETAILhttps://phabricator.wikimedia.org/T170039EMAIL PREF
daniel added a comment.
Hm... it might be timing related, but I don't see any recent edit to the connected item either https://www.wikidata.org/w/index.php?title=Q201495&action="">.TASK DETAILhttps://phabricator.wikimedia.org/T170039EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/
JohnBlackburne added a comment.
I mean to Category:Pages with script errors. The link at the top of the page lists them by the date they were added. As always seems to be the case with this error no edit triggers it; it can happen to actively edited pages or to pages that have not been edited for m
Jarekt added a comment.
Yes totally at random. You make some change to a page that does not have anything to do with wikidata, preview the page and see the error, click preview again without changing anything and the error is gone. Probability of it happening was small but I was changing a lot of p
daniel added a comment.
@Jarekt @JohnBlackburne: so you are saying this happens at random? Or it happens when a page gets re-parsed under some specific condition, and then vanishes when the page is parsed again after a purge? That seems unlikely, though it's not impossible...
When you say "Māui P
JohnBlackburne added a comment.
And another one just (2 minutes ago) added to the category: [[Kingdom Hearts II]] Kingdom Hearts II. It’s still happening.TASK DETAILhttps://phabricator.wikimedia.org/T170039EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JohnBl
Jarekt added a comment.
Daniel, I have not seen this error in some days now, but when it occurred purging was usually enough to fix it. It seemed to me that any save, page preview or purge of a page accessing Wikidata had some small probability of showing this error, and a new purge was a new cast
JohnBlackburne added a comment.
It has always been the case that the pages can be fixed by purging – that was noted in the initial report. Purging is easy if you know to do it and how to do it, but many if not most editors, never mind readers, will not know to do so. And it is the nature of the pro
daniel added a comment.
@JohnBlackburne So you confirm that it is not happening any more. There are still bad renderings in the parser cache, but the root cause seems to have been fixed, su puring the page fixes the rendering. We should still find out what happened, and a mass purge of the affected
JohnBlackburne added a comment.
It’s still happening. I went through a portion of the articles in the en.wp category yesterday and found one more. And as I check again there are only two articles in the category but one has the problem (until someone purges it): Māui Pōmare.TASK DETAILhttps://phabr
daniel added a comment.
@ValterVB can you confirm that all pages you found can be fixed by purging them?TASK DETAILhttps://phabricator.wikimedia.org/T170039EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: daniel, putnik, Framawiki, Zebulon84, Thibaut1
Lydia_Pintscher added a comment.
Thank you for reporting this. I asked the team to have a look.TASK DETAILhttps://phabricator.wikimedia.org/T170039EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: Framawiki, Zebulon84, Thibaut120094, TerraCode
Liuxinyu970226 added a comment.
In T170039#3441889, @Thibaut120094 wrote:
Same problem on frwiki with pages that use Lua infoboxes.
Probably in Module:Bandeau where:
`local function femininFromWikidata()
local entity = mw.wikibase.getEntity() --Why not local entity = mw.wikibase.getEntityObject
ValterVB added a comment.
Just to know n° 2: I have checked the first 120 page in italian wiki that are in search result: 52 show the problem with red message.TASK DETAILhttps://phabricator.wikimedia.org/T170039EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: V
JohnBlackburne added a comment.
In T170039#3441925, @ValterVB wrote:
Just to know: yesterday I emptied the category "Pages with script errors" on italian wikipedia (18:20) now, after 18 hours the category has 723 pages, and increasing continuously
I went through the en.wp category yesterday, as
Vachovec1 added a comment.
In T170039#3441616, @Liuxinyu970226 wrote:
In T170039#3441308, @Vachovec1 wrote:
Bumping priority. This NEEDS attention.
Are you sure, absolutely sure, that without resolving this task many pages and many scripts will not render/work properly? If not, how do you think
ValterVB added a comment.
Just to know: yesterday I emptied the category "Pages with script errors" on italian wikipedia (18:20) now, after 18 hours the category has 723 pages, and increasing continuouslyTASK DETAILhttps://phabricator.wikimedia.org/T170039EMAIL PREFERENCEShttps://phabricator.wikime
Thibaut120094 added a comment.
In T170039#3441616, @Liuxinyu970226 wrote:
In T170039#3441308, @Vachovec1 wrote:
Bumping priority. This NEEDS attention.
Are you sure, absolutely sure, that without resolving this task many pages and many scripts will not render/work properly?
Yes, see the scree
Thibaut120094 added a comment.
Same problem on frwiki with pages that use Lua infoboxes.TASK DETAILhttps://phabricator.wikimedia.org/T170039EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Thibaut120094Cc: Thibaut120094, TerraCodes, Jay8g, Liuxinyu970226, aude,
Liuxinyu970226 added a comment.
In T170039#3441308, @Vachovec1 wrote:
Bumping priority. This NEEDS attention.
Are you sure, absolutely sure, that without resolving this task many pages and many scripts will not render/work properly? If not, how do you think this is suitable for UBN?TASK DETAILht
Vachovec1 added a comment.
An example of a completely broken page:
F8771865: Capture_2017_07_15_15_48_00_78.jpgTASK DETAILhttps://phabricator.wikimedia.org/T170039EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Vachovec1Cc: Vachovec1, Zdzislaw, ValterVB, Agab
Vachovec1 added a comment.
Because this error can completely break pages (although the problem can be repaired through a purge), I suggest UBN! priority.TASK DETAILhttps://phabricator.wikimedia.org/T170039EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Vachove
Vachovec1 added a comment.
In T170039#3431944, @ValterVB wrote:
Also in it wikipedia we have the problem. You can check this with search: https://it.wikipedia.org/w/index.php?search=The+entity+data+must+be+a+table+obtained+via+mw.wikibase.getEntityObject.&title=Speciale:Ricerca&go=Vai&searchToken
ValterVB added a comment.
Also in it wikipedia we have the problem. You can check this with search: https://it.wikipedia.org/w/index.php?search=The+entity+data+must+be+a+table+obtained+via+mw.wikibase.getEntityObject.&title=Speciale:Ricerca&go=Vai&searchToken=awzuqflixgt8xl9yuq0lzqmtgTASK DETAILht
Jarekt added a comment.
I was first alerted about it on July 8, (see [[ User_talk:Jarekt#Template:PD-Polish | here ]] or here) but today it happened to me too (see below) . In both cases issue happen on Commons and purging solved the problem.
F8684904: New Picture (1).jpgTASK DETAILhttps://phabric
JohnBlackburne added a comment.
It is not just one big red message. It is as many as there are uses of Wikidata on the page, sometimes showing the error message above, sometimes something else as it tries to use that as input to something, and it’s not uncommon to see two, sometimes more. Here is A
101 - 138 of 138 matches
Mail list logo
