gerritbot added a comment.
Change 382462 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Add new icons for constraint violations
https://gerrit.wikimedia.org/r/382462TASK DETAILhttps://phabricator.wikimedia.org/T171586EMAIL PREFERENCEShttps://phabricator.wikimedia.o
Lucas_Werkmeister_WMDE added a comment.
But also, the non-mandatory icon is larger again… it looks like OO.ui (or whatever it is that loads the icons – perhaps it’s a property of the browser directly?) just ignores the SVG’s declared size, so if you’re designing an icon set, the icons need to have
Lucas_Werkmeister_WMDE added a comment.
Hm, I think the outline thing on the non-mandatory icon isn’t so helpful, because now there are masks in the SVG, which I don’t understand at all :) fortunately, I was able to replace the entire border with an identical-looking , since all the required coordi
Hanna_Petruschat_WMDE added a comment.
So here it comes again. Hope the cleanup helped as discussed.
F10140821: WD_Constraints-again-again.zipTASK DETAILhttps://phabricator.wikimedia.org/T171586EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Hanna_Petruschat_W
Lucas_Werkmeister_WMDE added a comment.
@Hanna_Petruschat_WMDE I’m here and mostly free now, feel free to come over.TASK DETAILhttps://phabricator.wikimedia.org/T171586EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, Charlie
Hanna_Petruschat_WMDE added a comment.
Alright. @Lucas_Werkmeister_WMDE, do you just want to let me know, when you're in and free to work on it and I'll come over? I feel it's easier to look at it side by side. Also: I'm happy to hear about cleaner svg's we can provide so the workflow gets more eff
Lucas_Werkmeister_WMDE added a comment.
Yeah, sure. Just a quick note – I’ve already cleaned up the exported SVG files (I’m about to upload the new versions), so I’d prefer some simple transformations I can apply to them (scale, translate) over a new ZIP of SVGs that I then clean up again from scra
Jan_Dittrich added a comment.
@Hanna_Petruschat_WMDE will probalby look at them on Monday, if that is fine.TASK DETAILhttps://phabricator.wikimedia.org/T171586EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jan_DittrichCc: gerritbot, Charlie_WMDE, Hanna_Petrus
Lydia_Pintscher added a comment.
The non-mandatory one. Not sure though if we should have different sizes. Might look weird if you have a mix of constraint violations on one item. But Hanna should comment.TASK DETAILhttps://phabricator.wikimedia.org/T171586EMAIL PREFERENCEShttps://phabricator.wikim
Lucas_Werkmeister_WMDE added a comment.
Just the non-mandatory one or both?TASK DETAILhttps://phabricator.wikimedia.org/T171586EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, Charlie_WMDE, Hanna_Petruschat_WMDE, Lydia_Pints
Lydia_Pintscher added a comment.
Much better! :) I feel like it is still a bit too big for people to be comfortable with. Hanna?TASK DETAILhttps://phabricator.wikimedia.org/T171586EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: gerritbot, Ch
Lucas_Werkmeister_WMDE added a comment.
Here’s how it looks now:
F10030851: Screenshot-2017-10-6 Douglas Adams.pngTASK DETAILhttps://phabricator.wikimedia.org/T171586EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, Charlie_W
Lucas_Werkmeister_WMDE added a comment.
Oh, I see, one SVG has a bounding box of 29×29 and the other has a bounding box of 21×21, but it looks like the icon ignores that. Adjusting the width/height/viewbox and the canvas transform works.TASK DETAILhttps://phabricator.wikimedia.org/T171586EMAIL PREF
Hanna_Petruschat_WMDE added a comment.
I don't know, why it enlargens the non-mandatory one, as I exported it in a smaller size. See the screenshot to compare:
F10021300: Screen Shot 2017-10-05 at 21.55.54.png
Is the 28x28 bounding box something that came with the exported svg or did you set that
Lucas_Werkmeister_WMDE added a comment.
Thanks, the strokes look a lot better now. But the non-mandatory icon still looks too large in my opinion… what if we rotate it by 45° (matching the mandatory icon)? Then it would be smaller if it still had to fit within the 28×28 bounding box.TASK DETAILhttp
Hanna_Petruschat_WMDE added a comment.
Oh my... That looks indeed very heavy and not as wanted. So let's give it another try. Thanks Lucas!
F10019421: WD_Constraints-again.zipTASK DETAILhttps://phabricator.wikimedia.org/T171586EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/email
Lucas_Werkmeister_WMDE added a comment.
Okay, here’s what it looks like on the page:
F10019379: Screenshot-2017-10-5 Douglas Adams.png
The “non-mandatory” icon is much bigger than in your mockup, which makes it more prominent than the “mandatory” icon, I think. Strokes in both icons also look a bit
Lucas_Werkmeister_WMDE added a comment.
Thanks! I’ll see what I can do with those SVGs.TASK DETAILhttps://phabricator.wikimedia.org/T171586EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot, Charlie_WMDE, Hanna_Petruschat_WMDE,
gerritbot added a comment.
Change 382462 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] WIP: New icons for constraint violations
https://gerrit.wikimedia.org/r/382462TASK DETAILhttps://phabri
Hanna_Petruschat_WMDE added a comment.
So here I have a zip with the icons as svgs included in original and 2x size. Let me know, if that works for you or if you need another format to implement them.
Also: as we are working with a new design tool, the export options are limited and I read they ar
Lydia_Pintscher added a comment.
Signed statements is what the icon is for - just naming confusion.TASK DETAILhttps://phabricator.wikimedia.org/T171586EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: Charlie_WMDE, Hanna_Petruschat_WMDE, Lydia
Lucas_Werkmeister_WMDE added a comment.
Thanks! Looks pretty nice.
I also did an icon for approved constraints (which are not shown yet, but will be in the future rumors say).
Hm, that’s news to me, I would think that’s a lot of unnecessary clutter… but on the other hand, it looks like a nice ico
daniel added a comment.
I like them! Putting the ! into a triangle would be more familiar to europeans, but a square box will do ;)TASK DETAILhttps://phabricator.wikimedia.org/T171586EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: Charlie_WMDE, Hanna
Lydia_Pintscher added a comment.
Looks good from my side :)TASK DETAILhttps://phabricator.wikimedia.org/T171586EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: Charlie_WMDE, Hanna_Petruschat_WMDE, Lydia_Pintscher, daniel, Aklapper, Jan_Dittri
Hanna_Petruschat_WMDE added a comment.
Thanks again Lukas for your feedback. It took me (and fair to say Lydia) quit a bit to understand the problem. I hope I got it right with the following solution.
As there gonna be explanation boxes for each problem, I decided to differ between non-mandatory c
Lucas_Werkmeister_WMDE added a comment.
Thanks for your suggestions, Hanna! I like the upper row, specifically the ? / ! part, which seems to reflect the distinction between non-mandatory constraints (“are you sure this is right?”) and mandatory constraints (“this can’t be right!”) very nicely.
Bu
Hanna_Petruschat_WMDE added a comment.
Here is another attempt on how to handle the warnings:
the current icons measure something around 24*24 px
the solutions favored before would lose clarity in details
the screenshot attached shows two ways factoring in the original size:
the upper row shows a
Jan_Dittrich added a comment.
I wouldn't go for the constraining shape because in the future it should also have other indicators in there like from checks against 3rd party databases.
The "clamp" shape would show that it is a (constraint) check, the inside could show its nature. The boxes have th
Lydia_Pintscher added a comment.
I like these: F8916027: image.png
I wouldn't go for the constraining shape because in the future it should also have other indicators in there like from checks against 3rd party databases.TASK DETAILhttps://phabricator.wikimedia.org/T171586EMAIL PREFERENCEShttps://
Jan_Dittrich added a comment.
Version without just ! as indicators and a "constraining" shape.
F8946708: image.pngTASK DETAILhttps://phabricator.wikimedia.org/T171586EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jan_DittrichCc: Lydia_Pintscher, daniel, Akla
Jan_Dittrich added a comment.
I think a bit of putting the indicator in a box, so we get around the confusion of info-i in a circle (usually it means help) and the "attention" icon being used for something similar. What I have in mind would be three icons with rising severity, maybe like: F8916027:
Lucas_Werkmeister_WMDE added a comment.
Currently, we have the following distinctions:
Statement with violations of non-mandatory constraints: “info” F8915840: image.png
Statement with violations of mandatory constraints (and also non-mandatory ones): “alert” F8915837: image.png
Invalid constrai
Jan_Dittrich added a comment.
@daniel The concern was in the direction of "will it make Wikidata unusable/ugly/… for anything but constraint fixing". That being prevented, I am totally for showing all this here :-)TASK DETAILhttps://phabricator.wikimedia.org/T171586EMAIL PREFERENCEShttps://phabrica
daniel added a comment.
@Jan_Dittrich, Lydia_Pintscher: I don't think it's relevant how rare the constraints are - I'm not even sure I know what that means. What matters is how rare violations of mandatory constraints are. And these should, by definition, be rare. If we have a lot of violations of
Jan_Dittrich added a comment.
In regards to the icons:
We could have a block icon
like F8848323: image.png
and an attention icon
like F8848325: image.png
(examples are from the tango iconset)
I find both slightly too alarming.
I could try to make an icon in a triangle, but with a i in it.
The
35 matches
Mail list logo
