Lucas_Werkmeister_WMDE added a comment.
This should be fixed with Ieea56a7686 , probably deployed on Wednesday.TASK DETAILhttps://phabricator.wikimedia.org/T173026EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDECc: gerritbot,
gerritbot added a comment.
Change 449737 abandoned by Lucas Werkmeister (WMDE):
Update data-values/geo to 2.1.2
Reason:
Obsoleted by Ieea56a7686.
https://gerrit.wikimedia.org/r/449737TASK DETAILhttps://phabricator.wikimedia.org/T173026EMAIL
gerritbot added a comment.
Change 449737 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/vendor@master] Update data-values/geo to 2.1.2
https://gerrit.wikimedia.org/r/449737TASK DETAILhttps://phabricator.wikimedia.org/T173026EMAIL
Lucas_Werkmeister_WMDE added a comment.
Hm, I don’t think the in_array is the issue – that only checks the $direction, after all, not anything from the $matches, so that should always have the right case. I think the issue is a few lines further up:
if ( $matches[1] === $direction || $matches[3]
Nikki added a comment.
I just ran into this problem again and was about to report it, only to find I already did a year ago...
I went hunting for the source of the problem and I think it might be in https://github.com/DataValues/Geo/blob/master/src/Parsers/LatLongParserBase.php#L219. The regex on
Izno added a comment.
The other alternative would be to treat 1 S 1 W as -1 N -1 E.TASK DETAILhttps://phabricator.wikimedia.org/T173026EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: IznoCc: Izno, Aklapper, Nikki, PokestarFan, GoranSMilovanovic, QZanden,
