gerritbot added a comment.
Change 421007 merged by jenkins-bot:
[wikidata/query/gui@master] Remove extra text-center class
https://gerrit.wikimedia.org/r/421007TASK DETAILhttps://phabricator.wikimedia.org/T178112EMAIL
gerritbot added a comment.
Change 421007 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[wikidata/query/gui@master] Remove extra text-center class
https://gerrit.wikimedia.org/r/421007TASK DETAILhttps://phabricator.wikimedia.org/T178112EMAIL
Lucas_Werkmeister_WMDE added a comment.
Well, this is how timeouts look now:
F15944814: Screenshot-2018-3-21 Wikidata Query Service.png
I don’t usually expect exception stack traces to look like poetry ;)TASK DETAILhttps://phabricator.wikimedia.org/T178112EMAIL
gerritbot added a comment.
Change 419660 merged by Smalyshev:
[wikidata/query/gui-deploy@production] Merging from eeeb286cdd9bd43123b492ac5430e16886f2b8fa:
https://gerrit.wikimedia.org/r/419660TASK DETAILhttps://phabricator.wikimedia.org/T178112EMAIL
Lucas_Werkmeister_WMDE added a comment.
In T178112#3682230, @Lucas_Werkmeister_WMDE wrote:
What we need to watch out for is how the browser behaves when reopening a closed tab or something like that – I’ve run into a few websites where in such a situation the text area is still filled in (because
gerritbot added a comment.
Change 418723 merged by jenkins-bot:
[wikidata/query/gui@master] Disallow empty query from running by showing an error message
https://gerrit.wikimedia.org/r/418723TASK DETAILhttps://phabricator.wikimedia.org/T178112EMAIL
Jonas added a comment.
This is how it will look:
F15379587: image.pngTASK DETAILhttps://phabricator.wikimedia.org/T178112EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: prssanna, JonasCc: gerritbot, Lucas_Werkmeister_WMDE, Jonas, Aklapper, Smalyshev,
gerritbot added a comment.
Change 41 abandoned by Prssanna:
Disallow empty query from running by showing an error message
https://gerrit.wikimedia.org/r/41TASK DETAILhttps://phabricator.wikimedia.org/T178112EMAIL
gerritbot added a comment.
Change 41 had a related patch set uploaded (by Prssanna; owner: Prssanna):
[wikidata/query/gui@master] Disallow empty query from running by showing an error message
https://gerrit.wikimedia.org/r/41TASK DETAILhttps://phabricator.wikimedia.org/T178112EMAIL
gerritbot added a comment.
Change 418723 had a related patch set uploaded (by Jonas Kress (WMDE); owner: Prssanna):
[wikidata/query/gui@master] Disallow empty query from running by showing an error message
https://gerrit.wikimedia.org/r/418723TASK
Lucas_Werkmeister_WMDE added a comment.
What we need to watch out for is how the browser behaves when reopening a closed tab or something like that – I’ve run into a few websites where in such a situation the text area is still filled in (because the browser restored it), but the UI isn’t updated,
Jonas added a comment.
It could show the cat query by default, just kidding :)
Seriously, maybe in addition to not penetrate the service with empty queries,
we could give some nice text and maybe also a button to open examples dialog.TASK DETAILhttps://phabricator.wikimedia.org/T178112EMAIL
12 matches
Mail list logo
