Smalyshev added a comment.
I think the leaks come from combination of RandomizedTesting, which insists on policing threads (not sure why randomization should come with thread policing?), some classes we use in tests using thread pools (Metrics has its own pools, Http clients too, also Zookeeper) an
gerritbot added a comment.
Change 401705 merged by jenkins-bot:
[wikidata/query/rdf@master] Properly close HC client in WikibaseRepository
https://gerrit.wikimedia.org/r/401705TASK DETAILhttps://phabricator.wikimedia.org/T178721EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emai
gerritbot added a comment.
Change 401705 had a related patch set uploaded (by Gehel; owner: Guillaume Lederrey):
[wikidata/query/rdf@master] Properly close HC client in WikibaseRepository
https://gerrit.wikimedia.org/r/401705TASK DETAILhttps://phabricator.wikimedia.org/T178721EMAIL PREFERENCEShttp
gerritbot added a comment.
Change 396380 merged by jenkins-bot:
[wikidata/query/rdf@master] Extract RdfRepositoryForTesting to a JUnit @Rule
https://gerrit.wikimedia.org/r/396380TASK DETAILhttps://phabricator.wikimedia.org/T178721EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/em
gerritbot added a comment.
Change 396380 had a related patch set uploaded (by Gehel; owner: Gehel):
[wikidata/query/rdf@master] Extract RdfRepositoryForTesting to a JUnit @Rule
https://gerrit.wikimedia.org/r/396380TASK DETAILhttps://phabricator.wikimedia.org/T178721EMAIL PREFERENCEShttps://phabric
Smalyshev added a comment.
Also, the problem unfortunately is not very well reproducible, it comes and goes, though it shows up often enough to be annoying. But of course, once I start debugging it locally, it vanishes.TASK DETAILhttps://phabricator.wikimedia.org/T178721EMAIL PREFERENCEShttps://pha
Smalyshev added a comment.
Blazegraph uses Jetty and I think I tried to use Apache with it and there were some problems. So I use Jetty to communicate to Blazegraph.TASK DETAILhttps://phabricator.wikimedia.org/T178721EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences
Gehel added a comment.
No idea what's going on here. I have seen the same error a few times as well. It looks like the leaked thread is an HttpClient, so my guess is that in some cases RdfRepository.httpClient isn't closed. But I can't understand in which code path this could happen. Looking deeper
Smalyshev added a comment.
@Gehel, do you have any thoughts on this?TASK DETAILhttps://phabricator.wikimedia.org/T178721EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Gehel, Aklapper, Smalyshev, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanov
