gerritbot added a comment.
Change 389698 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Restore wgCirrusSearchRescoreFunctionScoreChains after test
https://gerrit.wikimedia.org/r/389698TASK DETAILhttps://phabricator.wikimedia.org/T179061EMAIL PREFERENCEShttps://phabricator.wikimedia
gerritbot added a comment.
Change 386602 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add integration tests for pasting full URLs into entity selectors
https://gerrit.wikimedia.org/r/386602TASK DETAILhttps://phabricator.wikimedia.org/T179061EMAIL PREFERENCEShttps://phabricator.wik
gerritbot added a comment.
Change 387025 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add special case handling for some forms of IDs
https://gerrit.wikimedia.org/r/387025TASK DETAILhttps://phabricator.wikimedia.org/T179061EMAIL PREFERENCEShttps://phabricator.wikimedia.org/setting
gerritbot added a comment.
Change 389698 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig):
[mediawiki/extensions/Wikibase@master] Restore wgCirrusSearchRescoreFunctionScoreChains after test
https://gerrit.wikimedia.org/r/389698TASK DETAILhttps://phabricator.wikimedi
gerritbot added a comment.
Change 387025 had a related patch set uploaded (by Smalyshev; owner: Smalyshev):
[mediawiki/extensions/Wikibase@master] Add special case handling for some forms of IDs
https://gerrit.wikimedia.org/r/387025TASK DETAILhttps://phabricator.wikimedia.org/T179061EMAIL PREFEREN
thiemowmde added a comment.
What about utilizing a try-catch? You can wrap it in a private passesEntityIdParsing function if you like.TASK DETAILhttps://phabricator.wikimedia.org/T179061EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: thiemowmdeCc: gerritbot, h
Smalyshev added a comment.
EntityIdParser throws exception on parse error. Is there any API that allows to check whether something is a valid ID without throwing?TASK DETAILhttps://phabricator.wikimedia.org/T179061EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To
thiemowmde added a comment.
I believe that even pasting a partial URL like "ata.org/wiki/Q42" should work. And it easily can, as I already tried to show above. Just try to apply two steps:
Try to parse the users input as an entity ID. We do have WikibaseRepo::getEntityIdParser() which should be u
Smalyshev added a comment.
Yes this is a problem... I wonder though whether we should cover all of these. I can see why one would paste the first one into the selector, but the other ones one would have to take from RDF or specially construct... Is it a reasonable expectation that search would cove
Multichill added a comment.
The url can be in different formats:
https://www.wikidata.org/wiki/Q42
http://www.wikidata.org/entity/Q42
https://www.wikidata.org/wiki/Special:EntityPage/Q42
Not sure how many variants we have. Not to hard to catch in a regex, might be a bit more clutter when you ad
Lydia_Pintscher added a comment.
I think we can keep it to Wikidata URLs.
Parenthesis removal should also work for the other entity types. I don't think we need it for labels etc.TASK DETAILhttps://phabricator.wikimedia.org/T179061EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/em
Smalyshev added a comment.
We could probably pre-process the input, yes. Though I am not sure we should encourage these things... while something like case-insensitive match is common search functionality, pasting URLs etc. with magic rules seems to be going a bit too far. But if old one supported
gerritbot added a comment.
Change 386602 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/Wikibase@master] Add integration tests for pasting full URLs into entity selectors
https://gerrit.wikimedia.org/r/386602TASK DETAILhttps://phabric
13 matches
Mail list logo
