PDrouin-WMF added a comment.
It looks like my June 11th comment (https://phabricator.wikimedia.org/T189145) got lost in the shuffle. UI copy will be complete when Description is updated to: “Provide all information that will help others understand what this file represents.” See below for more
gerritbot added a comment.
Change 434652 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/UploadWizard@master] Redesign arrow steps
https://gerrit.wikimedia.org/r/434652TASK DETAILhttps://phabricator.wikimedia.org/T188502EMAIL
Ramsey-WMF added a comment.
Note: We'll leave this ticket in until UI copy work is complete and we're ready to move to prod.TASK DETAILhttps://phabricator.wikimedia.org/T188502EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: matthiasmullie, Ramsey-WMFCc:
gerritbot added a comment.
Change 415332 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Add caption input fields
https://gerrit.wikimedia.org/r/415332TASK DETAILhttps://phabricator.wikimedia.org/T188502EMAIL
gerritbot added a comment.
Change 415331 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Make uw.Description(s)DetailsWidget.js more generic
https://gerrit.wikimedia.org/r/415331TASK DETAILhttps://phabricator.wikimedia.org/T188502EMAIL
gerritbot added a comment.
Change 419403 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Improve upload error handling
https://gerrit.wikimedia.org/r/419403TASK DETAILhttps://phabricator.wikimedia.org/T188502EMAIL
Ramsey-WMF added a comment.
Thanks for the detailed feedback @kaldari . We're in the process of researching how to improve wording for the instructional text, and JMo is helping us run a study/survey that you can track here (https://phabricator.wikimedia.org/T190428)
In T188502#4106220,
kaldari added a comment.
Here are my impressions as a Beta Tester...
Personal background for context: Long-time Commons user and administrator (over 2,000 file uploads and 17,000 edits on Commons), also helped write the UploadWizard (sorry!)
The UI looks good and seems to work great (I tried
PDrouin-WMF added a comment.
I double-checked the design style guide (https://wikimedia.github.io/WikimediaUI-Style-Guide/visual-style_icons.html) and if the icon is 18x20, that should be fine.
From the guide:
"Icons follow a template. The default canvas is 20 x 20 dp. In order to allow for
matthiasmullie added a comment.
Not sure about the trash icon dimensions. The element it is 24px wide (default OOUI icon min width), but part of that is white edges. I'd guess the icon itself is about 18x20 or so.
Which would you like to make smaller? The one on the right of the textareas, the one
Ramsey-WMF added a comment.
A few small items for fixes/changes:
existing bug: the down arrows on the language selector buttons for Caption and Description don't show up on PC (this has been there for...a long time. would be nice to get it fixed finally :) )
When adding captions in both
matmarex added a comment.
In T188502#4049984, @matthiasmullie wrote:
Something along these lines:
F15408086: Screenshot 2018-03-14 15.27.42.png
Please also display the caption that we failed to submit, so that the user can copy-paste it.TASK DETAILhttps://phabricator.wikimedia.org/T188502EMAIL
matthiasmullie added a comment.
I've given the error handling some more thought and am not convinced we need to (attempt to) roll back the upload, should submitting captions fail.
Here's what could go wrong submitting captions:
invalid user input: we should validate this before submitting, so
gerritbot added a comment.
Change 419403 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/UploadWizard@master] Improve upload error handling
https://gerrit.wikimedia.org/r/419403TASK DETAILhttps://phabricator.wikimedia.org/T188502EMAIL
Ramsey-WMF added a comment.
Responses to @matthiasmullie
I'd like to see caption length mirror file name uses cases (with the addition of being more mutable and multilingual). 255 characters seems good to me as a max length.
I think, for the summer launch, it may be most prudent to have the
matthiasmullie added a comment.
The caption was not displayed on that screenshot since it's currently implemented as optional - that's how the description widget already worked.
I've just changed it now so it always show an input, even if not required - empty input will just be ignored.
Few more
PDrouin-WMF added a comment.
Also @matthiasmullie - the button that takes users to the next step needs to be changed to "Published" per: https://phabricator.wikimedia.org/T182307TASK DETAILhttps://phabricator.wikimedia.org/T188502EMAIL
PDrouin-WMF added a comment.
@Ramsey-WMF it's still unresolved in my mind whether a caption character limit must be enforced or not. Should there be a hard limit? If so, how much? It's out of my wheelhouse to determine how much, especially given the plethora of languages. Can we treat the
PDrouin-WMF added a comment.
@Base that google presentation was the rough draft which became this design consultation with the community: https://commons.wikimedia.org/wiki/Commons:Structured_data/Get_involved/Feedback_requests/Multilingual_Captions#DiscussionTASK
Base added a comment.
See https://docs.google.com/presentation/d/1ACN_ZRPbHVah5lwPBdeYLoHheiHtQ2gK4_lGhnLEVcQ/edit#slide=id.g2efa5e495e_0_14
Is there a version of description of this task that does not require logging into a Google account?TASK DETAILhttps://phabricator.wikimedia.org/T188502EMAIL
PDrouin-WMF added a comment.
@matthiasmullie you said above:
As I understand it, we want to encourage short captions.
Does that mean we need to enforce them even if there are no technical reasons for doing so? Or do we just want to nudge people towards writing succinct descriptions, without
PDrouin-WMF added a comment.
@matthiasmullie - it's looking good! Two things.
First, Caption should look just like Description (language dropdown field and text box for caption). Wireframe: F14642908: Screenshot 2018-03-07 09.53.54.png
Second, should Caption be required, not optional --
Cparle added a comment.
As for support in different languages: assuming we have no other research, we could start out with Twitter's findings of nudging people towards in most languages, and in Chinese, Japanese & Korean?
This sounds reasonable to me
A hard limit based on a _javascript_
matthiasmullie added a comment.
Pam: does this look alright?
F14629173: Screenshot 2018-03-05 15.59.06.png
So.. how do we proceed wrt the character count?
Does anyone have a suggestion for length and how we convey it? :)TASK DETAILhttps://phabricator.wikimedia.org/T188502EMAIL
Ramsey-WMF added a comment.
Does that mean we need to enforce them even if there are no technical reasons for doing so?
Yes. Caption is a short field. We'll have a multilingual "description" field as well, for the longer summaries.TASK DETAILhttps://phabricator.wikimedia.org/T188502EMAIL
gerritbot added a comment.
Change 416466 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/UploadWizard@master] Improve what details step looks like
https://gerrit.wikimedia.org/r/416466TASK DETAILhttps://phabricator.wikimedia.org/T188502EMAIL
matthiasmullie added a comment.
As I understand it, Twitter currently:
has a fixed limit of 280 (most languages) or 140 (Chinese, Japanese, and Korean)
that limit is the amount of characters, not the amount of bytes (so characters requiring more bytes only count 1 towards the total allowed
PDrouin-WMF added a comment.
@matthiasmullie in my research, I've had people share this info:
In MediaWiki there is module to enforce limits on text fields that are limited to certain number of bytes in the database:
gerritbot added a comment.
Change 415332 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/UploadWizard@master] [WIP] Add caption input fields
https://gerrit.wikimedia.org/r/415332TASK DETAILhttps://phabricator.wikimedia.org/T188502EMAIL
gerritbot added a comment.
Change 415331 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/UploadWizard@master] Make uw.Description(s)DetailsWidget.js more generic
https://gerrit.wikimedia.org/r/415331TASK
matthiasmullie added a comment.
A few questions:
What is the minimum & maximum length for caption input? (descriptions, right now, are expected to be between 5 and 1 characters)
Is a caption required? (a description, right now, is required)
If required: are there cases where it may not be
31 matches
Mail list logo
