Addshore added a comment.
All APIs and special pages edit using services / classes / code provided by WIkibase, all of which check the edit rate limits.
I'm not entirely sure how testable this is, but we could write an integration test for each API endpoint ensuring the rate limit is checked.TASK D
gerritbot added a comment.
Change 423968 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/WikibaseLexeme@master] Test rate limit for all custom APIs and special pages
https://gerrit.wikimedia.org/r/423968TASK DETAILhttps://phabricator.wikimedia.org/T189483EMAI
Addshore added a comment.
Moving to peer review.
Selenium / browser tests are not really possible here as we can't easily change the configuration for a single test.
All UI actions use the API anyway, so as long as the API returns the expected error in the default format the UI should handle that.T
gerritbot added a comment.
Change 423968 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Test rate limit for all custom APIs and special pages
https://gerrit.wikimedia.org/r/423968TASK DETAILhttps://phabricator.wikimedia.org/T189483EMAIL PREFERENCEShttps://phabricator.wikimedia