gerritbot added a comment.
Change 434011 abandoned by Zfilipin:
Do not run composer in WikibaseLexeme's node selenium job
Reason:
no activity in months
https://gerrit.wikimedia.org/r/434011
TASK DETAIL
https://phabricator.wikimedia.org/T191537
EMAIL PREFERENCES
https://phabr
gerritbot added a comment.
Change 445222 had a related patch set uploaded (by Hashar; owner: Hashar):
[mediawiki/core@master] In development, run all jobs on each requests
https://gerrit.wikimedia.org/r/445222TASK DETAILhttps://phabricator.wikimedia.org/T191537EMAIL PREFERENCEShttps://phabricator.
gerritbot added a comment.
Change 439289 merged by jenkins-bot:
[mediawiki/core@master] Disable WebResponse setters for post-send processing
https://gerrit.wikimedia.org/r/439289TASK DETAILhttps://phabricator.wikimedia.org/T191537EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/em
hashar added a comment.
From https://gerrit.wikimedia.org/r/c/mediawiki/core/+/439289
Wikibase was failing the Selenium tests which are run by the 'quibble' job at least for the php7. It might be faster and thus ended up hitting the race condition.
I have crafted a dummy change for Wikibase whic
gerritbot added a comment.
Change 439289 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] Disable WebResponse::setCookie() for post-send processing
https://gerrit.wikimedia.org/r/439289TASK DETAILhttps://phabricator.wikimedia.org/T191537EMAIL PREFERENCEShttps://
Anomie added a comment.
In T191537#4267565, @hashar wrote:
Seems to be the jobs should never set a cookie to cover the case of them being run by a web request.
Unfortunately it's probably something down the call stack that's defaulting to some property of the session user where the job itself do
hashar added a comment.
Yup, I think the flow goes like:
POST /index.php/Special:Preferences
user=User-0.8234
COOKIE: wikidb_session=0js640qarj8b7c710hboopll3d99jo9l
Several jobs get enqueued and one is left behind. That got triggered by a run of the mediawiki/core Selenium tests. The suite then
Anomie added a comment.
In T191537#4267131, @hashar wrote:
So I think the POST /index.php/Special:UserLogin completes properly and then a job is processed. That happens to be a cirrusSearchLinksUpdatePrioritized that got enqueued by a previous request/test, it then mess up with the session on the
hashar added a comment.
Maybe I will try tonight to have all the jobs issued by a request to be run immediately. $wgJobRunRate = PHP_INT_MAX; would do it.
Though there are some sleep() calls in the MediaWiki jobrunner which might well delay the job run time :(TASK DETAILhttps://phabricator.wikimed
hashar added a comment.
So I think the POST /index.php/Special:UserLogin completes properly and then a job is processed. That happens to be a cirrusSearchLinksUpdatePrioritized that got enqueued by a previous request/test, it then mess up with the session on the server side and the user ends up log
hashar added a comment.
For the HHVM job that passed ( https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/4849/ ), there is no other requests happening during the redirect:
$ egrep '(wikidb_session|COOKIE|Start request)' hhvm.log
5ab822f040f89e5522c663b8 Start request POST
hashar added a comment.
From https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php70-docker/5475/artifact/log/mw-debug-www.log The lines come from the debug log and are prefixed with `\WebRequest::getRequestId().
A request to [Special:Preferences] made with a normal user:
9ff423f95888
hashar added a comment.
Thank you @Anomie
I hacked mediawiki core to present the webrequest id to all debug log ( Gerrit 438232 ). That might help sorting out the logs and tracking what is going on a per web request basis.
I then made a Wikibase change to depend on that patch. A Selenium test f
hashar added a comment.
I have tried locally with ./node_modules/.bin/wdio --mochaOpts.grep 'should be re-creatable' but I could not reproduce the issue. That seems to be related to the session management. Potentially due to some objects not being written to the objectcache? :(TASK DETAILhttps://
hashar added a comment.
Looking at mediawiki-core-qunit-selenium-jessie #20109 triggered for WikibaseLexeme https://gerrit.wikimedia.org/r/#/c/434907/ :
A webdriver.io test from mediawiki/core fails when trying to restore a page. The test is supposed to be logged in as admin to do the action, howe
zeljkofilipin added a comment.
mediawiki-core-qunit-selenium-jessie/20110 passed 🤔TASK DETAILhttps://phabricator.wikimedia.org/T191537EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipinCc: gerritbot, Anomie, hashar, Jakob_WMDE, Addshore, Pablo-WMDE,
zeljkofilipin added a comment.
mediawiki-core-qunit-selenium-jessie/20109 failed different test 😱
00:05:12.053 [chrome #0-1] Spec: /home/jenkins/workspace/mediawiki-core-qunit-selenium-jessie/src/tests/selenium/specs/page.js
00:05:12.054 [chrome #0-1] Running: chrome
00:05:12.054 [chrome #0-1]
00:
WMDE-leszek added a comment.
meh, looks like the similar we've been getting with the job using composer.TASK DETAILhttps://phabricator.wikimedia.org/T191537EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipin, WMDE-leszekCc: gerritbot, Anomie, hashar,
zeljkofilipin added a comment.
mediawiki-core-qunit-selenium-jessie/20108 failed 🤔
00:08:05.665 [chrome #0-2] Spec: /home/jenkins/workspace/mediawiki-core-qunit-selenium-jessie/src/tests/selenium/specs/user.js
00:08:05.666 [chrome #0-2] Running: chrome
00:08:05.666 [chrome #0-2]
00:08:05.666 [chro
gerritbot added a comment.
Change 434917 merged by jenkins-bot:
[integration/config@master] Run qunit-selenium job for WikibaseLexeme in experimental pipeline
https://gerrit.wikimedia.org/r/434917TASK DETAILhttps://phabricator.wikimedia.org/T191537EMAIL PREFERENCEShttps://phabricator.wikimedia.org
gerritbot added a comment.
Change 434917 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[integration/config@master] Run qunit-selenium job for WikibaseLexeme in experimental pipeline
https://gerrit.wikimedia.org/r/434917TASK DETAILhttps://phabricator.wikimedia.org/T191537EMAIL PR
gerritbot added a comment.
Change 434011 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[integration/config@master] Do not run composer in WikibaseLexeme's node selenium job
https://gerrit.wikimedia.org/r/434011TASK DETAILhttps://phabricator.wikimedia.org/T191537EMAIL PREFE
Anomie added a comment.
The one thing that looks odd to me is this request:
Start request POST /jenkins-mwext-mw-selenium-node-composer-jessie-178/index.php/Special:UserLogin
HTTP HEADERS:
HOST: localhost:9412
CONNECTION: keep-alive
CONTENT-LENGTH: 198
CACHE-CONTROL: max-age=0
ORIGIN: http://local
WMDE-leszek added a comment.
I've made https://gerrit.wikimedia.org/r/#/c/426857/ to get some videos using the great patch you're working on @zeljkofilipin.
https://integration.wikimedia.org/ci/job/mwext-mw-selenium-node-composer-jessie/138/artifact/log/User-should-be-able-to-change-preferences.mp4
zeljkofilipin added a comment.
116 passed (425268/4), 118 failed (425268/5).
curl https://integration.wikimedia.org/ci/job/mwext-mw-selenium-node-composer-jessie/116/consoleText > 116
curl https://integration.wikimedia.org/ci/job/mwext-mw-selenium-node-composer-jessie/118/consoleText > 118
diff
WMDE-leszek added a comment.
It is probably not needed for this task, but it would be of great if I could run the tests locally. I don't know which mediawiki-vagrant role to enable to get WikibaseLexeme running. wikibase_repo, wikidata...?
sadly we didn't get to adding any vagrant role yet.
I beli
26 matches
Mail list logo
