MarcoAurelio added a comment.
Thanks for your assistance TASK DETAILhttps://phabricator.wikimedia.org/T191634EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lucas_Werkmeister_WMDE, MarcoAurelioCc: Dereckson, mmodell, gerritbot, thiemowmde,
Lucas_Werkmeister_WMDE added a comment.
See https://gerrit.wikimedia.org/r/425076 (I didn’t add a link to this task because I don’t think it’s really a part of this anymore, just a follow-up).TASK DETAILhttps://phabricator.wikimedia.org/T191634EMAIL
Lucas_Werkmeister_WMDE added a comment.
I don't think it should return the unnormalized original string.
Well, at least I see no reason not to return the normalized string when the API actually gave it to us, just because the page happens to be missing. But I guess that’s a separate change.TASK
gerritbot added a comment.
Change 424849 merged by jenkins-bot:
[mediawiki/core@master] Fix (MediaWiki)Site::normalizePageName return type
https://gerrit.wikimedia.org/r/424849TASK DETAILhttps://phabricator.wikimedia.org/T191634EMAIL
gerritbot added a comment.
Change 424629 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Handle normalizePageName() returning non-string values
https://gerrit.wikimedia.org/r/424629TASK DETAILhttps://phabricator.wikimedia.org/T191634EMAIL
thiemowmde added a comment.
What would be the alternative when we remove all return false from MediaWikiPageNameNormalizer::normalizePageName? I don't think it should return the unnormalized original string. In my opinion it would need to throw an exception – which means all code that currently
gerritbot added a comment.
Change 424849 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/core@master] Fix (MediaWiki)Site::normalizePageName return type
https://gerrit.wikimedia.org/r/424849TASK DETAILhttps://phabricator.wikimedia.org/T191634EMAIL
gerritbot added a comment.
Change 424629 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Handle normalizePageName() returning non-string values
https://gerrit.wikimedia.org/r/424629TASK
Lucas_Werkmeister_WMDE added a comment.
Also, what do we do now? Do we update the documentation of core’s normalizePageName functions to make clear that they can also return false, and change SpecialItemByTitle to deal with the false possibility; or should they be changed to not return false
Lucas_Werkmeister_WMDE added a comment.
Sorry, I used the API sandbox incorrectly, the API does return something. But the case is very simple – if the API reports that the page is missing, then MediaWikiPageNameNormalizer::normalizePageName returns false.
The only open question is why this hasn’t
Lucas_Werkmeister_WMDE added a comment.
At a guess, I’d say that the most likely cause seems that the API request would in the past have returned a normalized title even for pages that don’t exist, and now it doesn’t anymore?
On a local install, such a request returns a proper title. And my
Lucas_Werkmeister_WMDE added a comment.
I think this might be what’s happening:
Wikibase attempts to normalize the title locally, and look up an item for that title. It fails.
Wikibase asks MediaWiki to normalize the title according to the rules of that wiki. ($siteObj->normalizePageName( $page
MarcoAurelio added a comment.
Another instance:
https://www.wikidata.org/w/index.php?title=Special%3AItemByTitle=enwiki=Protecci%C3%B3n+de+datos
[Wsd6uwpAADgAAICpXDMAAACP] 2018-04-06 13:48:44: Fatal exception of type "Wikimedia\Assert\ParameterTypeException"TASK
13 matches
Mail list logo
