[Wikidata-bugs] [Maniphest] [Commented On] T192006: wdqs-frontend docker image should (BLUBBER) rebuild automatically when a new patch is pushed to master

gerritbot added a comment. Change 472649 abandoned by Addshore: WIP DNM add blubber.yml https://gerrit.wikimedia.org/r/472649 TASK DETAIL https://phabricator.wikimedia.org/T192006 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc

[Wikidata-bugs] [Maniphest] [Commented On] T192006: wdqs-frontend docker image should (BLUBBER) rebuild automatically when a new patch is pushed to master

Addshore added a comment. In T192006#5658106 , @Ladsgroup wrote: > I'm in favor of turning the GUI into a nodejs app that serves static files for now and then slowly turning it into a full-fledged nodejs one. @Addshore do you think this

[Wikidata-bugs] [Maniphest] [Commented On] T192006: wdqs-frontend docker image should (BLUBBER) rebuild automatically when a new patch is pushed to master

Ladsgroup added a comment. I'm in favor of turning the GUI into a nodejs app that serves static files for now and then slowly turning it into a full-fledged nodejs one. @Addshore do you think this is doable? TASK DETAIL https://phabricator.wikimedia.org/T192006 EMAIL PREFERENCES https:/

[Wikidata-bugs] [Maniphest] [Commented On] T192006: wdqs-frontend docker image should (BLUBBER) rebuild automatically when a new patch is pushed to master

gerritbot added a comment. Change 489386 abandoned by Ladsgroup: [WIP] [POC] Add blubber and turn it to a nodejs serve-static server Reason: We are not doing this for now https://gerrit.wikimedia.org/r/489386 TASK DETAIL https://phabricator.wikimedia.org/T192006 EMAIL PREFEREN

[Wikidata-bugs] [Maniphest] [Commented On] T192006: wdqs-frontend docker image should (BLUBBER) rebuild automatically when a new patch is pushed to master

Ladsgroup added a comment. I added basic serve-static nodejs libraries that can unblock us from using nginx and it's a good direction to have a nodejs server (then we can inject configs, etc.). Now I have two issues with prep and deployment: prep needs to have env=prod, that makes npm omit instal

[Wikidata-bugs] [Maniphest] [Commented On] T192006: wdqs-frontend docker image should (BLUBBER) rebuild automatically when a new patch is pushed to master

gerritbot added a comment. Change 489386 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup): [wikidata/query/gui@master] [WIP] [POC] Add blubber and turn it to a nodejs serve-static server https://gerrit.wikimedia.org/r/489386TASK DETAILhttps://phabricator.wikimedia.org/T192006EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T192006: wdqs-frontend docker image should (BLUBBER) rebuild automatically when a new patch is pushed to master

Addshore added a comment. In T192006#4881895, @thcipriani wrote: Is the nginx base image because you have both a nodejs service listening on a socket in addition to static files that need to be served? No, it is currently only static files. Node is needed to build them, but they can currently be

[Wikidata-bugs] [Maniphest] [Commented On] T192006: wdqs-frontend docker image should (BLUBBER) rebuild automatically when a new patch is pushed to master

thcipriani added a comment. Is the nginx base image because you have both a nodejs service listening on a socket in addition to static files that need to be served?TASK DETAILhttps://phabricator.wikimedia.org/T192006EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/

[Wikidata-bugs] [Maniphest] [Commented On] T192006: wdqs-frontend docker image should (BLUBBER) rebuild automatically when a new patch is pushed to master

Addshore added a comment. In T192006#4851658, @Lydia_Pintscher wrote: Should this stay in the camp iteration then? I believe so, I think that is the purpose of the stalled column there now. We still want to get this done as soon as it is unblocked, rather than removing it from the iteration and

[Wikidata-bugs] [Maniphest] [Commented On] T192006: wdqs-frontend docker image should (BLUBBER) rebuild automatically when a new patch is pushed to master

Lydia_Pintscher added a comment. Should this stay in the camp iteration then?TASK DETAILhttps://phabricator.wikimedia.org/T192006EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Lydia_PintscherCc: Lydia_Pintscher, Joe, gerritbot, akosiaris, thcipriani, Addshore

[Wikidata-bugs] [Maniphest] [Commented On] T192006: wdqs-frontend docker image should (BLUBBER) rebuild automatically when a new patch is pushed to master

Addshore added a comment. PS2 @ https://gerrit.wikimedia.org/r/#/c/wikidata/query/gui/+/472649/2 has "test" and "development" fully working. Now I just have to figure out what to do with "prep" and "production"TASK DETAILhttps://phabricator.wikimedia.org/T192006EMAIL PREFERENCEShttps://phabricator.

[Wikidata-bugs] [Maniphest] [Commented On] T192006: wdqs-frontend docker image should (BLUBBER) rebuild automatically when a new patch is pushed to master

Addshore added a comment. So I pushed a patch of my work in progress blubber file. test currently fails as a qunit test fails: Running "qunit:all" (qunit) task Testing wikibase/tests/index.html ..FF >> wikibase.queryService.a

[Wikidata-bugs] [Maniphest] [Commented On] T192006: wdqs-frontend docker image should (BLUBBER) rebuild automatically when a new patch is pushed to master

gerritbot added a comment. Change 472649 had a related patch set uploaded (by Addshore; owner: Addshore): [wikidata/query/gui@master] WIP DNM add blubber.yml https://gerrit.wikimedia.org/r/472649TASK DETAILhttps://phabricator.wikimedia.org/T192006EMAIL PREFERENCEShttps://phabricator.wikimedia.org/

[Wikidata-bugs] [Maniphest] [Commented On] T192006: wdqs-frontend docker image should (BLUBBER) rebuild automatically when a new patch is pushed to master

Addshore added a comment. So, I gave it another go, and then realized that I wasn't running the docker build with --no-cache. We might want to work --no-cache into the https://wikitech.wikimedia.org/wiki/Blubber#Example_usage section incase people like me forget. I then also realized that my build

[Wikidata-bugs] [Maniphest] [Commented On] T192006: wdqs-frontend docker image should (BLUBBER) rebuild automatically when a new patch is pushed to master

Addshore added a comment. I was on this: $ blubber --version 0.4.0+9bfa2dd Will give it a go with this today :) $ blubber --version 0.6.0+7450643TASK DETAILhttps://phabricator.wikimedia.org/T192006EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc:

[Wikidata-bugs] [Maniphest] [Commented On] T192006: wdqs-frontend docker image should (BLUBBER) rebuild automatically when a new patch is pushed to master

thcipriani added a comment. In T192006#4731938, @Addshore wrote: So, while trying to move this to blubber I hit the first issue. $ docker run --rm -it wdqs-gui-test-$(date --iso) > wikidata-query-gui@0.1.4 test /srv/service > grunt test >> Local Npm module "grunt-auto-install" not found. Is