[Wikidata-bugs] [Maniphest] [Commented On] T193005: EntityHandler::getTitleForId should handle FormIDs

2018-04-30 Thread gerritbot
gerritbot added a comment. Change 429157 merged by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Test that forms can be added as data values in statements on properties https://gerrit.wikimedia.org/r/429157TASK DETAILhttps://phabricator.wikimedia.org/T193005EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T193005: EntityHandler::getTitleForId should handle FormIDs

2018-04-27 Thread gerritbot
gerritbot added a comment. Change 429399 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Use TypeDispatchingEntityTitleStoreLookup instead of EntityContentFactory https://gerrit.wikimedia.org/r/429399TASK DETAILhttps://phabricator.wikimedia.org/T193005EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T193005: EntityHandler::getTitleForId should handle FormIDs

2018-04-27 Thread Jakob_WMDE
Jakob_WMDE added a comment. For the record, the proposed patch does not make EntityHandler::getTitleForId handle forms, but instead ensures that the custom TitleLookup for forms is used insteadTASK DETAILhttps://phabricator.wikimedia.org/T193005EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T193005: EntityHandler::getTitleForId should handle FormIDs

2018-04-27 Thread gerritbot
gerritbot added a comment. Change 429399 had a related patch set uploaded (by Jakob; owner: Jakob): [mediawiki/extensions/Wikibase@master] Use TypeDispatchingEntityTitleStoreLookup instead of EntityContentFactory https://gerrit.wikimedia.org/r/429399TASK

[Wikidata-bugs] [Maniphest] [Commented On] T193005: EntityHandler::getTitleForId should handle FormIDs

2018-04-26 Thread gerritbot
gerritbot added a comment. Change 429157 had a related patch set uploaded (by Jakob; owner: Jakob): [mediawiki/extensions/WikibaseLexeme@master] EntityHandler::getTitleForId should handle FormIds https://gerrit.wikimedia.org/r/429157TASK DETAILhttps://phabricator.wikimedia.org/T193005EMAIL