[Wikidata-bugs] [Maniphest] [Commented On] T193636: [Bug] new representation or Lemma with same language code overwrites existing representation

2018-06-04 Thread gerritbot
gerritbot added a comment. Change 436806 merged by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Representation language: Add aria-invalid https://gerrit.wikimedia.org/r/436806TASK DETAILhttps://phabricator.wikimedia.org/T193636EMAIL PREFERENCEShttps://phabricator.wikimedia.org/setting

[Wikidata-bugs] [Maniphest] [Commented On] T193636: [Bug] new representation or Lemma with same language code overwrites existing representation

2018-06-04 Thread Lydia_Pintscher
Lydia_Pintscher added a comment. Pablo and I just discussed this and to be consistent with all the other places we could find (Form representation, statements, term box) we should disable the Lemma widget's submit button when there is invalid input.TASK DETAILhttps://phabricator.wikimedia.org/T1936

[Wikidata-bugs] [Maniphest] [Commented On] T193636: [Bug] new representation or Lemma with same language code overwrites existing representation

2018-06-01 Thread gerritbot
gerritbot added a comment. Change 436800 merged by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Representation language: Pre-existing bind syntax https://gerrit.wikimedia.org/r/436800TASK DETAILhttps://phabricator.wikimedia.org/T193636EMAIL PREFERENCEShttps://phabricator.wikimedia.org

[Wikidata-bugs] [Maniphest] [Commented On] T193636: [Bug] new representation or Lemma with same language code overwrites existing representation

2018-06-01 Thread gerritbot
gerritbot added a comment. Change 435189 merged by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Form representations: Prevent redundant langugages https://gerrit.wikimedia.org/r/435189TASK DETAILhttps://phabricator.wikimedia.org/T193636EMAIL PREFERENCEShttps://phabricator.wikimedia.or

[Wikidata-bugs] [Maniphest] [Commented On] T193636: [Bug] new representation or Lemma with same language code overwrites existing representation

2018-06-01 Thread gerritbot
gerritbot added a comment. Change 436806 had a related patch set (by Pablo Grass (WMDE)) published: [mediawiki/extensions/WikibaseLexeme@master] Representation language: Add aria-invalid https://gerrit.wikimedia.org/r/436806TASK DETAILhttps://phabricator.wikimedia.org/T193636EMAIL PREFERENCEShttps

[Wikidata-bugs] [Maniphest] [Commented On] T193636: [Bug] new representation or Lemma with same language code overwrites existing representation

2018-06-01 Thread gerritbot
gerritbot added a comment. Change 436800 had a related patch set (by Pablo Grass (WMDE)) published: [mediawiki/extensions/WikibaseLexeme@master] Representation language: Pre-existing bind syntax https://gerrit.wikimedia.org/r/436800TASK DETAILhttps://phabricator.wikimedia.org/T193636EMAIL PREFEREN

[Wikidata-bugs] [Maniphest] [Commented On] T193636: [Bug] new representation or Lemma with same language code overwrites existing representation

2018-06-01 Thread Pablo-WMDE
Pablo-WMDE added a comment. @Lydia_Pintscher Lexeme lemmas and form representations use two rather different UX paradigms. This was the case already before this ticket was started but as we are now also dealing with validation and error messages we have to use one approach or the other. Lemmas o

[Wikidata-bugs] [Maniphest] [Commented On] T193636: [Bug] new representation or Lemma with same language code overwrites existing representation

2018-05-31 Thread Pablo-WMDE
Pablo-WMDE added a comment. https://gerrit.wikimedia.org/r/#/c/435189/ representation part is ready for review https://gerrit.wikimedia.org/r/#/c/436554/ lemma part is WIPTASK DETAILhttps://phabricator.wikimedia.org/T193636EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailprefe

[Wikidata-bugs] [Maniphest] [Commented On] T193636: [Bug] new representation or Lemma with same language code overwrites existing representation

2018-05-30 Thread Lydia_Pintscher
Lydia_Pintscher added a comment. I updated the description as discussed.TASK DETAILhttps://phabricator.wikimedia.org/T193636EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Pablo-WMDE, Lydia_PintscherCc: gerritbot, Lea_Lacroix_WMDE, Aklapper, Lydia_Pintscher, V