RexxS added a comment.
Yes, I've just found that out by testing.
I assume that means opening a new ticket?TASK DETAILhttps://phabricator.wikimedia.org/T193857EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: RexxSCc: Tgr, RexxS, JJMC89, Aklapper, Liuxinyu970226
Pbsouthwood added a comment.
Sounds like a practical plan.TASK DETAILhttps://phabricator.wikimedia.org/T193857EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: PbsouthwoodCc: Tgr, RexxS, JJMC89, Aklapper, Liuxinyu970226, Pbsouthwood, Lahi, Gq86, GoranSMilovanovi
Alsee added a comment.
@Pbsouthwood, I also originally thought the simple and obvious answer was to use the first description. I definitely see some ugly and backwards aspects of using noreplace. However on deep thought, noreplace is probably the right answer. Consider an infobox that tries to add
Pbsouthwood added a comment.
This is worse if people use a bare magic word (not encased in the short description template, so the short description does not show using css as it has allocated class. The upside is that these have mostly been added at the bottom of articles, the downside is that this
gerritbot added a comment.
Change 437222 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/Wikibase@master] Handle {{SHORTDESC:...|noreplace}}
https://gerrit.wikimedia.org/r/437222TASK DETAILhttps://phabricator.wikimedia.org/T193857EMAIL PREFERENCEShttps:
Pbsouthwood added a comment.
I am happy to see some action here. Is there an explanation somewhere of how this will work, so we can plan ahead? cheersTASK DETAILhttps://phabricator.wikimedia.org/T193857EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tgr, Pbsou
Tgr added a comment.
Exactly as described in T193857#4209931, if it goes through code review unchanged.TASK DETAILhttps://phabricator.wikimedia.org/T193857EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TgrCc: gerritbot, Alsee, Tgr, RexxS, JJMC89, Aklapper, Li
Pbsouthwood added a comment.
"if there is an invocation without noreplace, that takes precedence over the noreplace ones."
If I understand this correctly, we must add noreplace to any magic word that can be replaced, and leave it out for the one which must not be replaced, which is a bit counterint
Tgr added a comment.
A better way to look at it is that you should add noreplace to everything that should not replace other, presumably more specific instances. So, use noreplace in templates, don't use noreplace in articles.TASK DETAILhttps://phabricator.wikimedia.org/T193857EMAIL PREFERENCEShttp
Pbsouthwood added a comment.
Suddenly it is clear! Thanks for that explanation. Like a figure and ground problem, it depends on how you first look at it..TASK DETAILhttps://phabricator.wikimedia.org/T193857EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tgr, P
Pbsouthwood added a comment.
If we were to add noreplace to all template inclusions, will it have any adverse effect. or should this wait until you are done?TASK DETAILhttps://phabricator.wikimedia.org/T193857EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tgr
Tgr added a comment.
It's generally best to wait at least until things get merged, as they might change shape until then.TASK DETAILhttps://phabricator.wikimedia.org/T193857EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TgrCc: gerritbot, Alsee, Tgr, RexxS, JJ
Pbsouthwood added a comment.
Fair enough.TASK DETAILhttps://phabricator.wikimedia.org/T193857EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Tgr, PbsouthwoodCc: gerritbot, Alsee, Tgr, RexxS, JJMC89, Aklapper, Liuxinyu970226, Pbsouthwood, Versusxo, Majesticalre
gerritbot added a comment.
Change 437222 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Handle {{SHORTDESC:...|noreplace}}
https://gerrit.wikimedia.org/r/437222TASK DETAILhttps://phabricator.wikimedia.org/T193857EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/email
14 matches
Mail list logo
