gerritbot added a comment.
Change 443044 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Include more details about composer running in README.md
https://gerrit.wikimedia.org/r/443044TASK DETAILhttps://phabricator.wikimedia.org/T197868EMAIL PREFERENCEShttps://phabricator.wikime
Addshore added a comment.
So @Tarrow @zeljkofilipin is this resolved?TASK DETAILhttps://phabricator.wikimedia.org/T197868EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Aklapper, gerritbot, WMDE-leszek, Tarrow, Addshore, zeljkofilipin, Gaboe420, Ve
Tarrow added a comment.
I'm happy to report I can repeat the problem; I guess the issue is something about the merge plugin not running until the first run after it is installed.
The solution seems to be to run composer install twice.
I'll add this to the readme.TASK DETAILhttps://phabricator.wik
gerritbot added a comment.
Change 443044 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/WikibaseLexeme@master] Include more details about composer running in README.md
https://gerrit.wikimedia.org/r/443044TASK DETAILhttps://phabricator.wikimedia.org/T197868EMAIL
Tarrow added a comment.
I will certainly take a look but I don't actually use the composer merge plugin.
I altered the instructions to use it after hearing from someone in the office that they've had a big discussion about it and it's the "right" way to do it. Perhaps it's actually clunkier..TASK
Addshore added a comment.
@Tarrow as you wrote the readme and I assume use the composer merge plugin any chance you could take a look at this?TASK DETAILhttps://phabricator.wikimedia.org/T197868EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: gerrit
zeljkofilipin added a comment.
My composer.local.json was always good, I have noticed that the readme was wrong in a desperate attempt to follow the instructions blindly. 🕶
So, nobody else can reproduce the problem?
Maybe there is something wrong with my machine. Do I need to have a specific vers
Addshore added a comment.
Does it work with the fix in the README from the patch?TASK DETAILhttps://phabricator.wikimedia.org/T197868EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: gerritbot, WMDE-leszek, Tarrow, Addshore, Aklapper, zeljkofilipin,
gerritbot added a comment.
Change 442283 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Add missing curly bracket to readme file
https://gerrit.wikimedia.org/r/442283TASK DETAILhttps://phabricator.wikimedia.org/T197868EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings
gerritbot added a comment.
Change 442283 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[mediawiki/extensions/WikibaseLexeme@master] Add missing curly bracket to readme file
https://gerrit.wikimedia.org/r/442283TASK DETAILhttps://phabricator.wikimedia.org/T197868EMAIL PREFERENCES
zeljkofilipin added a comment.
In T197868#4318830, @Addshore wrote:
but wikibase/data-model still isn't in your composer.lock?
No.
Could be some sort of bug with the composer merge plugin?
🤷♂️
All I can think of suggestion is remove you vendor dir and the composer.lock file and try again.
D
Addshore added a comment.
H
Nothing to install or update
but wikibase/data-model still isn't in your composer.lock?
Could be some sort of bug with the composer merge plugin?
All I can think of suggestion is remove you vendor dir and the composer.lock file and try again.TASK DETAILhttps://ph
zeljkofilipin added a comment.
In T197868#4312358, @Addshore wrote:
It doesn't look like you have done the "Install the dependencies with composer:" step in the WikibaseLexeme readme.
But I did:
~/Documents/gerrit/mediawiki/core$ docker run -it --rm --user $(id -u):$(id -g) -v ~/.composer:/comp
Addshore added a comment.
In T197868#4311706, @zeljkofilipin wrote:
@Addshore P7288
Okay, so https://packagist.org/packages/wikibase/data-model isn't listed there at all.
It doesn't look like you have done the "Install the dependencies with composer:" step in the WikibaseLexeme readme.
What is
Addshore added a comment.
@zeljkofilipin Can you paste a copy of the composer.lock file in your root mediawiki dir?TASK DETAILhttps://phabricator.wikimedia.org/T197868EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: WMDE-leszek, Tarrow, Addshore, Ak
zeljkofilipin added a comment.
I am following instructions from addshore/mediawiki-docker-dev and wikimedia/mediawiki-extensions-WikibaseLexeme. I am at docker-compose exec "web" php /var/www/mediawiki/maintenance/update.php --wiki default --quick step of WikibaseLexeme's readme file. I can provide
Addshore added a comment.
Have you run composer update / install on both mediawiki and Wikibase and WikibaseLexeme?
Or are you using the composer merge-plugin to install all extension deps under the core vendor dir?
Or are you using the mediawiki-vendor git repo?TASK DETAILhttps://phabricator.wikim
zeljkofilipin added a comment.
Thanks, I did run docker system prune and docker system prune --volumes. I still get the same error message. 😢TASK DETAILhttps://phabricator.wikimedia.org/T197868EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: zeljkofilipinCc: WM
WMDE-leszek added a comment.
I am not a docker ninja, but when in a need to remove ALL docker stuff I use: docker system prune.
Note that it is going to remove all stopped containers, not only mediawiki ones (if you have others running).
Also keep in mind the note about volumes from the docs (i.e.
zeljkofilipin added a comment.
I don't have much experience with Docker, so in attempt to start clean, I have deleted addshore/mediawiki-docker-dev, mediawiki/core, Wikibase and WikibaseLexeme repositories and cloned them again. I get the same error message. I think I remember the instructions work
20 matches
Mail list logo
