[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

gerritbot added a comment. Change 506573 abandoned by BPirkle: Remove references to db fields rev_text_id and ar_text_id Reason: Extremely outdated https://gerrit.wikimedia.org/r/506573 TASK DETAIL https://phabricator.wikimedia.org/T198341 EMAIL PREFERENCES https://phabricat

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

gerritbot added a comment. Change 538599 restored by Daimona Eaytoy: Use a BlobStore for storing var dumps. Reason: This can be rebased on top of Icada720ab62d187f2dd0c4760697e465f2ff to remove any concern about back-compat stuff. @Daniel would you like to do that yourself, o

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

gerritbot added a comment. Change 524560 abandoned by Daniel Kinzler: Revision::getRevisionText(): support old schemas Reason: per Anomie's comment https://gerrit.wikimedia.org/r/524560 TASK DETAIL https://phabricator.wikimedia.org/T198341 EMAIL PREFERENCES https://phabricat

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

gerritbot added a comment. Change 442358 abandoned by Daniel Kinzler: MCR WIP Remove references to rev_text_id and ar_text_id Reason: Obsolete,see I5ea972bb07ca1cfb3a2ad8ef120aef77e460745c https://gerrit.wikimedia.org/r/442358 TASK DETAIL https://phabricator.wikimedia.org/T1983

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

gerritbot added a comment. Change 538599 abandoned by Daniel Kinzler: Use a BlobStore for storing var dumps. Reason: see I22cf698c5be77506727cbd227c67e037a5d89b5c https://gerrit.wikimedia.org/r/538599 TASK DETAIL https://phabricator.wikimedia.org/T198341 EMAIL PREFERENCES ht

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

gerritbot added a comment. Change 538599 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler): [mediawiki/extensions/AbuseFilter@master] Use a BlobStore for stroing var dumps. https://gerrit.wikimedia.org/r/538599 TASK DETAIL https://phabricator.wikimedia.org/

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

gerritbot added a comment. Change 538113 had a related patch set uploaded (by Ppchelko; owner: Ppchelko): [mediawiki/extensions/WikimediaMaintenance@master] Remove obsolete scripts that use rev_text_id. https://gerrit.wikimedia.org/r/538113 TASK DETAIL https://phabricator.wikimedia.o

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

gerritbot added a comment. Change 524593 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler): [mediawiki/extensions/Translate@master] Remove direct access to text table https://gerrit.wikimedia.org/r/524593 TASK DETAIL https://phabricator.wikimedia.org/T198341

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

daniel added a comment. It seems like our search for usages in extensions failed to take into account usages in joins. There is quite a bit of code that does this. Critically, the Translate extension heavily depends on rev_text_id in joins. Here's the code search: https://codesearch.w

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

gerritbot added a comment. Change 524560 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler): [mediawiki/core@master] Revision::getRevisionText(): support old schemas https://gerrit.wikimedia.org/r/524560 TASK DETAIL https://phabricator.wikimedia.org/T198341

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

gerritbot added a comment. Change 58 had a related patch set uploaded (by BPirkle; owner: BPirkle): [mediawiki/extensions/Duplicator@master] Only use the revision.rev_text_id if it exists. https://gerrit.wikimedia.org/r/58 TASK DETAIL https://phabricator.wikimedia.org/T198341

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

gerritbot added a comment. Change 506325 **merged** by jenkins-bot: [mediawiki/core@master] Remove references to db field ar_text_id https://gerrit.wikimedia.org/r/506325 TASK DETAIL https://phabricator.wikimedia.org/T198341 EMAIL PREFERENCES https://phabricator.wikimedia.org/setti

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

gerritbot added a comment. Change 506573 had a related patch set uploaded (by BPirkle; owner: BPirkle): [mediawiki/extensions/DeletePagesForGood@master] Remove references to db fields rev_text_id and ar_text_id https://gerrit.wikimedia.org/r/506573 TASK DETAIL https://phabricator.wik

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

Anomie added a comment. I don't think ApiQueryDeletedrevs will need larger changes, actually. Like the other accesses to `old_id`, the JOIN with `text` there was just to prefetch fields for a call to `Revision::getRevisionText()`. Removing the JOIN will just make the later `getRevisionText()

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

gerritbot added a comment. Change 506325 had a related patch set uploaded (by BPirkle; owner: BPirkle): [mediawiki/core@master] Remove referencs to db field ar_text_id https://gerrit.wikimedia.org/r/506325 TASK DETAIL https://phabricator.wikimedia.org/T198341 EMAIL PREFERENCES http

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

BPirkle added a comment. I'm also seeing three few ungated ar_text_id references in core: - ApiQueryAllDeletedRevisions::run() - ApiQueryDeletedRevisions::run() - ApiQueryDeletedrevs::execute() These all use ar_text_id to load content by joining the text table. I'll refactor that

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

gerritbot added a comment. Change 500755 **merged** by jenkins-bot: [mediawiki/core@master] Remove references to field rev_text_id https://gerrit.wikimedia.org/r/500755 TASK DETAIL https://phabricator.wikimedia.org/T198341 EMAIL PREFERENCES https://phabricator.wikimedia.org/setting

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

daniel added a comment. I still see a couple of usages of rev_text_id or ar_text_id in extensions that will need to be fixed[1]: - ActionDeletePagePermanently.php in DeletePagesForGood - Duplicator.page.php in Duplicator - bug-53687/fixOrphans.php in WikimediaMaintenance can probably

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

gerritbot added a comment. Change 499013 **merged** by jenkins-bot: [mediawiki/core@master] Remove references to field rev_text_id https://gerrit.wikimedia.org/r/499013 TASK DETAIL https://phabricator.wikimedia.org/T198341 EMAIL PREFERENCES https://phabricator.wikimedia.org/setting

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

gerritbot added a comment. Change 500755 had a related patch set uploaded (by BPirkle; owner: BPirkle): [mediawiki/core@master] Remove references to field rev_text_id https://gerrit.wikimedia.org/r/500755 TASK DETAIL https://phabricator.wikimedia.org/T198341 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

gerritbot added a comment. Change 499013 had a related patch set uploaded (by BPirkle; owner: BPirkle): [mediawiki/core@master] Remove references to field rev_text_id https://gerrit.wikimedia.org/r/499013 TASK DETAIL https://phabricator.wikimedia.org/T198341 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

daniel added a comment. In T198341#5049455 , @Anomie wrote: > In T198341#5046541 , @daniel wrote: > > > And let's look into fixing postgres later. And by "later" I mean "when there

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

Anomie added a comment. The annoying bit is that the join condition for `pagecontent` will look something like `old_id = substring( content_address from '^tt:(8[0-9]+)$' )::int`, which hard-codes the "tt:". Thankfully PG has that regexp-based substring and casting NULL to `int` works right o

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

daniel added a comment. In T198341#5046362 , @Anomie wrote: > Yes, we //could// do something like that. Probably we wouldn't even need to change the triggers, just the SeachPostgres code to join revision↔slots↔content↔text (and that las

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

Anomie added a comment. In T198341#502 , @BPirkle wrote: > To make sure I'm heading in the right direction: > > - Postgres currently uses columns in specific tables (pagecontent.textvector and page.titlevector, both of type tsvec

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

daniel added a comment. In T198341#502 , @BPirkle wrote: > To make sure I'm heading in the right direction: > > - Postgres currently uses columns in specific tables (pagecontent.textvector and page.titlevector, both of type tsvec

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

BPirkle added a comment. In T198341#5024626 , @Anomie wrote: > In T198341#5022412 , @daniel wrote: > > > In T198341#5021347 , @BPi

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

gerritbot added a comment. Change 496816 **merged** by jenkins-bot: [mediawiki/core@master] Remove many references to db fields being retired as part of MCR Schema Migration https://gerrit.wikimedia.org/r/496816 TASK DETAIL https://phabricator.wikimedia.org/T198341 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

gerritbot added a comment. Change 496816 had a related patch set uploaded (by BPirkle; owner: BPirkle): [mediawiki/core@master] Remove many references to db fields being retired as part of MCR Schema Migration https://gerrit.wikimedia.org/r/496816 TASK DETAIL https://phabricator.wiki

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

gerritbot added a comment. Change 496816 had a related patch set uploaded (by BPirkle; owner: BPirkle): [mediawiki/core@master] Remove many references to db fields being retired as part of MCR Schema Migration https://gerrit.wikimedia.org/r/496816 TASK DETAIL https://phabricator.wiki

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

daniel added a comment. In T198341#5025722 , @BPirkle wrote: > Should compressOld.php and trackBlobs.php be in the same patch, as they both suffer from the " processing multiple blobs per revision" problem? Oh, right. Yea, probab

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

BPirkle added a comment. In T198341#5025536 , @daniel wrote: > In T198341#5024626 , @Anomie wrote: > > > Here's one place where Daniel and I differ: I'd put most of these in one pat

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

daniel added a comment. In T198341#5024626 , @Anomie wrote: > Here's one place where Daniel and I differ: I'd put most of these in one patch instead of having 10+ single-file changes. Ok, compromise: one patch for SearchPostgres,

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

daniel added a comment. In T198341#5021347 , @BPirkle wrote: > rev_text_id references that will be removed/refactored in this task: > > - includes/Revision/RevisionStore.php (I'll touch only getQueryInfo(). All other references are

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

daniel added a comment. > includes/Revision/RevisionStore.php (I'll touch only getQueryInfo(). All other references are either gated directly, or are in private functions with all calls gated) getQueryInfo() should have proper gating as well. If you think it does not, let's talk before

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

BPirkle added a comment. Thanks. MessageCache.php was not listed in my previous comment, because I've already incorporated Daniel's patch from June into my local codebase, but that'll be part of the final change as well. TASK DETAIL https://phabricator.wikimedia.org/T198341 EMAIL PRE

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

BPirkle added a comment. Thank you. Will ping Tim on that one when it is daylight for him. One more question: rev_text_id is referenced in tests/phpunit/includes/ActorMigrationTest.php function provideInsertRoundTrip, which is a data provider for function testInsertRoundTrip. That functi

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

BPirkle added a comment. Question on one occurrence of these fields: is the maintenance script fixT22757.php still relevant? TASK DETAIL https://phabricator.wikimedia.org/T198341 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: BPirkle Cc: gerrit

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

daniel added a comment. In T198341#4962428, @BPirkle wrote: Task description refers to "RevisionStore::newRevisionRecordFromRow()". Should that be "RevisionStore::newRevisionFromRow()"? Yes, sorry about that. I'll fix the description.TASK DETAILhttps://phabricator.wikimedia.org/T198341EMAIL PRE

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

BPirkle added a comment. Task description refers to "RevisionStore::newRevisionRecordFromRow()". Should that be "RevisionStore::newRevisionFromRow()"?TASK DETAILhttps://phabricator.wikimedia.org/T198341EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BPirkleCc

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

gerritbot added a comment. Change 442358 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler): [mediawiki/core@master] MCR WIP Remove references to rev_text_id and ar_text_id https://gerrit.wikimedia.org/r/442358TASK DETAILhttps://phabricator.wikimedia.org/T198341EMAIL PREFE