[Wikidata-bugs] [Maniphest] [Commented On] T201950: Edit button broken in new toolbars in embed

2018-08-26 Thread prssanna
prssanna added a comment. Earlier, if this happened then the button would act as "edit with SPARQL editor" and a new tab would open. So should we make it behave like that?TASK DETAILhttps://phabricator.wikimedia.org/T201950EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T201950: Edit button broken in new toolbars in embed

2018-08-21 Thread Smalyshev
Smalyshev added a comment. Can we make it display something sensible instead of broken UI when such an error happens?TASK DETAILhttps://phabricator.wikimedia.org/T201950EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Aklapper, prssanna, Jonas,

[Wikidata-bugs] [Maniphest] [Commented On] T201950: Edit button broken in new toolbars in embed

2018-08-16 Thread Jonas
Jonas added a comment. The problem is SPARQL.js tries to parse the query and then fails with the error when trying to resolve the prefix. I am afraid we cannot do anything about it. A workaround would be defining the prefix in the query or in the default prefixes ...TASK

[Wikidata-bugs] [Maniphest] [Commented On] T201950: Edit button broken in new toolbars in embed

2018-08-15 Thread Smalyshev
Smalyshev added a comment. Since it's external query, the target server may know what foaf: is. And in any case, even if query syntax doesn't parse, it should not break the GUI. The 404 may be separate problem, as I am seeing it on other queries too.TASK

[Wikidata-bugs] [Maniphest] [Commented On] T201950: Edit button broken in new toolbars in embed

2018-08-15 Thread Jonas
Jonas added a comment. It seems foaf prefix is not defined wdqs.min.0968a8fe8abab9fafb2d.js:1 Error: Unknown prefix: foafTASK DETAILhttps://phabricator.wikimedia.org/T201950EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: JonasCc: Aklapper, prssanna, Jonas,