gerritbot added a comment.
Change 454064 abandoned by Pablo Grass (WMDE):
phpunit: relish MediaWikiTestCase db setup
Reason:
Mirrored (and then discontinued) in I2fb89ebeded45f97fa91aaf773ac55ee77314e86
https://gerrit.wikimedia.org/r/454064TASK
gerritbot added a comment.
Change 458458 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] EntityIdFormatterFactory: expect Language input
https://gerrit.wikimedia.org/r/458458TASK DETAILhttps://phabricator.wikimedia.org/T202223EMAIL
gerritbot added a comment.
Change 457886 merged by jenkins-bot:
[mediawiki/extensions/Math@master] Ensure database tests run as part of --group Database
https://gerrit.wikimedia.org/r/457886TASK DETAILhttps://phabricator.wikimedia.org/T202223EMAIL
gerritbot added a comment.
Change 455482 abandoned by Physikerwelt:
Fix broken test in quibble
Reason:
root cause for this issue was fixed
https://gerrit.wikimedia.org/r/455482TASK DETAILhttps://phabricator.wikimedia.org/T202223EMAIL
gerritbot added a comment.
Change 458163 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Replace SpecialWhatLinksHereTest with equivalent LexemeApiQueryBacklinksTest
https://gerrit.wikimedia.org/r/458163TASK DETAILhttps://phabricator.wikimedia.org/T202223EMAIL
gerritbot added a comment.
Change 458458 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Wikibase@master] EntityIdFormatterFactory: prepare for param change
https://gerrit.wikimedia.org/r/458458TASK
gerritbot added a comment.
Change 458163 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/WikibaseLexeme@master] Replace SpecialWhatLinksHereTest with equivalent LexemeApiQueryBacklinksTest
https://gerrit.wikimedia.org/r/458163TASK
gerritbot added a comment.
Change 457886 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Math@master] Ensure database tests run as part of --group Database
https://gerrit.wikimedia.org/r/457886TASK DETAILhttps://phabricator.wikimedia.org/T202223EMAIL
Physikerwelt added a comment.
It would be great if someone could merge https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Math/+/455482/ so that the failing tests do not block other developments. Thank you in advance.TASK DETAILhttps://phabricator.wikimedia.org/T202223EMAIL
WMDE-leszek added a comment.
Just run tests (--testsuite extensions --group Database --exclude-group Broken,ParserFuzz,Stub) with Wikibase, WikibaseLexeme and Math enabled, and both in case of master, and https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Math/+/455482/10 there is no test
Physikerwelt added a comment.
I could not see the warning for core tests. For example https://integration.wikimedia.org/ci/job/mediawiki-quibble-composer-mysql-php70-docker/5420/consoleTASK DETAILhttps://phabricator.wikimedia.org/T202223EMAIL
WMDE-leszek added a comment.
Will run tests in a sec as requested. Will report results shortly.
Isn't the quoted warning though something which is printed in basically all PHPunit runs in extensions since couple of weeks at least?TASK DETAILhttps://phabricator.wikimedia.org/T202223EMAIL
Pablo-WMDE added a comment.
This is likely caused by T202266. Should it turn out this remains a problem after T202266 is fixed, please resurrect/report again.TASK DETAILhttps://phabricator.wikimedia.org/T202223EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
Physikerwelt added a comment.
I am not sure what to do. Creating all tables is certainly a workaround. However, that would be different from the production setup and create tables that might never be used. I suspected that it could be related to the use of the globals to access the config.
gerritbot added a comment.
Change 455482 had a related patch set uploaded (by Physikerwelt; owner: Physikerwelt):
[mediawiki/extensions/Math@master] Avoid globals in MathRenderer::getValidModes
https://gerrit.wikimedia.org/r/455482TASK DETAILhttps://phabricator.wikimedia.org/T202223EMAIL
Pablo-WMDE added a comment.
This looks like getValidModes is called before the ExtensionRegistration stuff sets the configs / globals, hence $wgMathValidModes is not an array
It is works for me locally when running through docker-compose exec --user root "web" bash
gerritbot added a comment.
Change 454064 had a related patch set uploaded (by Pablo Grass (WMDE); owner: Pablo Grass (WMDE)):
[mediawiki/extensions/Math@master] phpunit: relish MediaWikiTestCase db setup
https://gerrit.wikimedia.org/r/454064TASK
Addshore added a comment.
In T202223#4514118, @Pablo-WMDE wrote:
by-catch when running (quibble) set-up with the math extension => T202266
Creating tables for enabled extensions
PHP Warning: array_map(): Argument #2 should be an array in /workspace/src/extensions/Math/src/MathRenderer.php on
Pablo-WMDE added a comment.
by-catch when running (quibble) set-up with the math extension:
Creating tables for enabled extensions
PHP Warning: array_map(): Argument #2 should be an array in /workspace/src/extensions/Math/src/MathRenderer.php on line 671
PHP Warning: in_array() expects
Pablo-WMDE added a comment.
Trying to reproduce in local quibble and see if changing NonTempTableTestCase to see if running its custom tear down on tearDown instead of tearDownAfterClass will help.TASK DETAILhttps://phabricator.wikimedia.org/T202223EMAIL
20 matches
Mail list logo
