WMDE-leszek added a comment.
Confirmed with @johl that the changes from the PR are basically it from his side. Will rebase the PR, and get it merged then!TASK DETAILhttps://phabricator.wikimedia.org/T202406EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: WMDE-l
Tarrow added a comment.
Rebased and made PR at https://github.com/wmde/wikibase-docker-yml-gui/pull/33TASK DETAILhttps://phabricator.wikimedia.org/T202406EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, TarrowCc: Tarrow, johl, WMDE-leszek, Aklapper, L
Tarrow added a comment.
Just asked the man in person; looks like it is good to go. I'll make the PRTASK DETAILhttps://phabricator.wikimedia.org/T202406EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, TarrowCc: Tarrow, johl, WMDE-leszek, Aklapper, Lydi
WMDE-leszek added a comment.
triggered by @Lydia_Pintscher's comment, I did some digging and found the fork of @johl It seem to have one commit ahead of the upstream with language changes: https://github.com/johl/wikibase-docker-yml-gui
It has not been made a PR to upstream, neither we've heard an
Addshore added a comment.
Looks like my change broke 1 message:
F26034584: image.png
Fixed in https://github.com/wmde/wikibase-docker-yml-gui/commit/c760384f3036b2f845015454e1bccea226af3e4bTASK DETAILhttps://phabricator.wikimedia.org/T202406EMAIL PREFERENCEShttps://phabricator.wikimedia.org/setti
Addshore added a comment.
In T202406#4595834, @Lydia_Pintscher wrote:
Did Jens' changes already get in?
I haven't seen any chances from Jens.TASK DETAILhttps://phabricator.wikimedia.org/T202406EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Tarr
Lydia_Pintscher added a comment.
Did Jens' changes already get in?TASK DETAILhttps://phabricator.wikimedia.org/T202406EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, Lydia_PintscherCc: Tarrow, johl, WMDE-leszek, Aklapper, Lydia_Pintscher, Gstupp, Abb
