[Wikidata-bugs] [Maniphest] [Commented On] T202427: [Bug] Adding a second Gloss in the same language overwrites existing Gloss

2018-09-17 Thread gerritbot
gerritbot added a comment. Change 459569 abandoned by Lucas Werkmeister (WMDE): WIP: Warn about sense glosses with duplicate language codes Reason: Superseded by Ifa48f76dff. https://gerrit.wikimedia.org/r/459569TASK DETAILhttps://phabricator.wikimedia.org/T202427EMAIL PREFERENCEShttps://phabrica

[Wikidata-bugs] [Maniphest] [Commented On] T202427: [Bug] Adding a second Gloss in the same language overwrites existing Gloss

2018-09-17 Thread gerritbot
gerritbot added a comment. Change 459564 merged by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Senses: Prevent redundant gloss languages https://gerrit.wikimedia.org/r/459564TASK DETAILhttps://phabricator.wikimedia.org/T202427EMAIL PREFERENCEShttps://phabricator.wikimedia.org/setting

[Wikidata-bugs] [Maniphest] [Commented On] T202427: [Bug] Adding a second Gloss in the same language overwrites existing Gloss

2018-09-10 Thread gerritbot
gerritbot added a comment. Change 459569 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseLexeme@master] WIP: Warn about sense glosses with duplicate language codes https://gerrit.wikimedia.org/r/459569TASK DETAILhttps:/

[Wikidata-bugs] [Maniphest] [Commented On] T202427: [Bug] Adding a second Gloss in the same language overwrites existing Gloss

2018-09-10 Thread gerritbot
gerritbot added a comment. Change 459564 had a related patch set uploaded (by Addshore; owner: Addshore): [mediawiki/extensions/WikibaseLexeme@master] WIP Senses: Prevent redundant gloss languages https://gerrit.wikimedia.org/r/459564TASK DETAILhttps://phabricator.wikimedia.org/T202427EMAIL PREFER

[Wikidata-bugs] [Maniphest] [Commented On] T202427: [Bug] Adding a second Gloss in the same language overwrites existing Gloss

2018-09-10 Thread Addshore
Addshore added a comment. @Lydia_Pintscher & #wmde-design how does this look? F25751927: image.png The Forms version looks like this: F25751935: image.png I could also switch the order of the add button and the error: F25751944: image.pngTASK DETAILhttps://phabricator.wikimedia.org/T202427EMAI

[Wikidata-bugs] [Maniphest] [Commented On] T202427: [Bug] Adding a second Gloss in the same language overwrites existing Gloss

2018-09-10 Thread gerritbot
gerritbot added a comment. Change 457919 abandoned by Lucas Werkmeister (WMDE): Check for duplicate gloss language codes Reason: This clearly goes against whatever we’re currently doing for similar cases elsewhere, whether I like it or not. https://gerrit.wikimedia.org/r/457919TASK DETAILhttps://

[Wikidata-bugs] [Maniphest] [Commented On] T202427: [Bug] Adding a second Gloss in the same language overwrites existing Gloss

2018-09-04 Thread gerritbot
gerritbot added a comment. Change 455863 abandoned by Ladsgroup: [WIP] Throw error when two glosses in a sense have the same language https://gerrit.wikimedia.org/r/455863TASK DETAILhttps://phabricator.wikimedia.org/T202427EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpref

[Wikidata-bugs] [Maniphest] [Commented On] T202427: [Bug] Adding a second Gloss in the same language overwrites existing Gloss

2018-09-04 Thread gerritbot
gerritbot added a comment. Change 457919 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseLexeme@master] Check for duplicate gloss language codes https://gerrit.wikimedia.org/r/457919TASK DETAILhttps://phabricator.wikime

[Wikidata-bugs] [Maniphest] [Commented On] T202427: [Bug] Adding a second Gloss in the same language overwrites existing Gloss

2018-08-28 Thread gerritbot
gerritbot added a comment. Change 455863 had a related patch set uploaded (by Ladsgroup; owner: Amir Sarabadani): [mediawiki/extensions/WikibaseLexeme@master] [WIP] Throw error when two glosses in a sense have the same language https://gerrit.wikimedia.org/r/455863TASK DETAILhttps://phabricator.wi

[Wikidata-bugs] [Maniphest] [Commented On] T202427: [Bug] Adding a second Gloss in the same language overwrites existing Gloss

2018-08-28 Thread Ladsgroup
Ladsgroup added a comment. This is a little bit more complex than it looks because the frontend sends exactly the same request when someone adds a gloss with duplicated language (invalid) or just changes the gloss (valid). So handling it in backend seems tricky or not even needed. We need to do the