Tarrow added a comment.
I believe now that https://gerrit.wikimedia.org/r/459505 is merged we can go ahead.
Jonas' -2
We need to first teach the hook to evaluate ranking information, otherwise we have a running condition that randomly sorts suggestions.
is, I believe, satisfied by the above patc
hoo added a comment.
What's the state of https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PropertySuggester/+/458187? @Jonas can it be merged?TASK DETAILhttps://phabricator.wikimedia.org/T202848EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Jonas, hooCc:
gerritbot added a comment.
Change 459505 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Teach EntitySelector._combineResults() to evaluate rank
https://gerrit.wikimedia.org/r/459505TASK DETAILhttps://phabricator.wikimedia.org/T202848EMAIL PREFERENCEShttps://phabricator.wikimedia.org
gerritbot added a comment.
Change 459505 had a related patch set uploaded (by Jonas Kress (WMDE); owner: Jonas Kress (WMDE)):
[mediawiki/extensions/Wikibase@master] Teach EntitySelector._combineResults() to evaluate rank
https://gerrit.wikimedia.org/r/459505TASK DETAILhttps://phabricator.wikimedia
gerritbot added a comment.
Change 458187 had a related patch set uploaded (by Jonas Kress (WMDE); owner: Jonas Kress (WMDE)):
[mediawiki/extensions/PropertySuggester@master] Change property suggester to use hook instead of monkey patching
https://gerrit.wikimedia.org/r/458187TASK DETAILhttps://pha