gerritbot added a comment.
Change 474676 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add hook to wait for views being loaded
https://gerrit.wikimedia.org/r/474676TASK DETAILhttps://phabricator.wikimedia.org/T204039EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/
gerritbot added a comment.
Change 474678 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Ensure lexemeview is loaded during debugging
https://gerrit.wikimedia.org/r/474678TASK DETAILhttps://phabricator.wikimedia.org/T204039EMAIL PREFERENCEShttps://phabricator.wikimedia.org/sett
gerritbot added a comment.
Change 474678 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/WikibaseLexeme@master] Ensure lexemeview is loaded during debugging
https://gerrit.wikimedia.org/r/474678TASK DETAILhttps://phabricator.wikimedia.org/T204039EMA
gerritbot added a comment.
Change 474676 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] Add hook to wait for views being loaded
https://gerrit.wikimedia.org/r/474676TASK DETAILhttps://phabricator.wikimedia.org/T204039EMAIL PREFEREN
Lucas_Werkmeister_WMDE added a comment.
Can we somehow introduce a dependency from wikibase.ui.entityViewInit on wikibase.lexeme.lexemeview, e. g. by introducing a hook in Wikibase to collect additional lexeme views, and use that during ResourceLoader registration? (I have no idea if that’s possibl
Michael added a comment.
So, after a lot of investigation I can basely confirm what is stated in the original description by @Jakob_WMDE(?):
EntityParserOutputGenerator line 244 loads wikibase.ui.entityViewInit
ViewLexemeAction concurrently loads wikibase.lexeme.lexemeview
This is also the reason
Addshore added a comment.
During the story time @Tarrow said that it might be worth asking @Jakob_WMDE about this a bitTASK DETAILhttps://phabricator.wikimedia.org/T204039EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, Lucas_Werkmeister_W
Tarrow added a comment.
Most curiously nothing explicitly depends on wikibase.lexeme.lexemeview however at first glance what appears backwards is wikibase.lexeme.view.ViewFactoryFactory is depended upon by jquery.wikibase.lexemeviewTASK DETAILhttps://phabricator.wikimedia.org/T204039EMAIL PREFERENC
Tarrow added a comment.
@Jakob_WMDE pointed out and I could reproduce that if running with chrome debug tools set to stop on caught exceptions there is a a notable one thrown on
extensions/Wikibase/view/resources/wikibase/view/ViewFactory.js#650:
because lexemeview is not found after looking for i
Tarrow added a comment.
I can now replicate it and clearing local storage doesn't help meTASK DETAILhttps://phabricator.wikimedia.org/T204039EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Tarrow, Jakob_WMDE, Nandana, Mringgaard, Lahi, Gq86, GoranSMi
Tarrow added a comment.
I wasn't able to replicate the problem. Seems @Jakob_WMDE managed to fix with clearing LocalStorageTASK DETAILhttps://phabricator.wikimedia.org/T204039EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: TarrowCc: Tarrow, Jakob_WMDE, Mringga
11 matches
Mail list logo
