nray added a comment.
Moving this to Ready for Signoff (and skipping QA) as there was no code written for this card.TASK DETAILhttps://phabricator.wikimedia.org/T204070EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: nrayCc: pmiazga, Lydia_Pintscher, Addshore,
nray added a comment.
Thanks for the feedback @Addshore and @pmiazga . Seems like putting it in the Wikimedia Client would be both practical and a good fit for this so I'm recommending to try that approach first.TASK DETAILhttps://phabricator.wikimedia.org/T204070EMAIL PREFERENCEShttps://phabricato
pmiazga added a comment.
I think that creating a new extension just to inject one extra tag is a bit overkill. Adding it to MW core is also not the best solution as it throws too many responsibilities to the Core package.
Adding to the Google Rich Cards can be an option, but then most probably we
nray added a comment.
Heard back from Brian Wolf (Security Engineer) on whether creating a new extension would require a security review. He had this to say:
Yes, security review is needed for all new extensions. This sounds pretty trivial though. The review would probably take 30 seconds. Just pi
Addshore added a comment.
I don't know much about the "Google Rich Cards" extension, but it sounds like it could fit well. When that extension detects that it is loaded in Wikibase it could add the extra sameAs stuff that we want linking to wikidata.
It would also make just as much sense to put it
nray added a comment.
Sent an email to the security team today clarifying if a security review would be needed for a new extension housing this code.TASK DETAILhttps://phabricator.wikimedia.org/T204070EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: nrayCc: Lyd
nray added a comment.
Is there any existing extension that does this already?
Google Rich Cards is the closest one I can find.
Should this live in the Google Rich Cards extension?
Pros: Already setup as an extension that outputs json-ld. Has well-defined responsibilities.
Cons: Looks like it do
nray added a comment.
Sent an email today to Lydia Pintscher (product manager for Wikidata) asking if her team could give us some feedback on whether one of the existing wikibase extensions would be a suitable place for this code to live.TASK DETAILhttps://phabricator.wikimedia.org/T204070EMAIL PRE
