Krinkle added a comment.
In T205301#4622512, @Smalyshev wrote:
Also, is it providing value to users?
I assume yes. It basically suggests properties that have been statistically frequently used on entities of this kind. It's useful but it's not search so we should not collect it as part of the sea
Stashbot added a comment.
Mentioned in SAL (#wikimedia-operations) [2018-09-27T18:49:21Z] Synchronized php-1.32.0-wmf.23/extensions/WikimediaEvents/modules/wikibase/ext.wikimediaEvents.completionClicks.js: SWAT: [[gerrit:463296|Ignore clicks with empty search string]] T205301 (duration: 00m 56s)TA
gerritbot added a comment.
Change 463296 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@wmf/1.32.0-wmf.23] Ignore clicks with empty search string
https://gerrit.wikimedia.org/r/463296TASK DETAILhttps://phabricator.wikimedia.org/T205301EMAIL PREFERENCEShttps://phabricator.wikimedia.or
gerritbot added a comment.
Change 463296 had a related patch set uploaded (by Smalyshev; owner: Smalyshev):
[mediawiki/extensions/WikimediaEvents@wmf/1.32.0-wmf.23] Ignore clicks with empty search string
https://gerrit.wikimedia.org/r/463296TASK DETAILhttps://phabricator.wikimedia.org/T205301EMAIL
Smalyshev added a comment.
Also, is it providing value to users?
I assume yes. It basically suggests properties that have been statistically frequently used on entities of this kind. It's useful but it's not search so we should not collect it as part of the search data.TASK DETAILhttps://phabricat
Krinkle added a comment.
In T205301#4621086, @Smalyshev wrote:
We should ignore such clicks.
Also, is it providing value to users? Or does it seem like a bug, that users might click out of confusion? Might be worth a follow up task to potentially remove in general.TASK DETAILhttps://phabricator.
gerritbot added a comment.
Change 463181 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@master] Ignore clicks with empty search string
https://gerrit.wikimedia.org/r/463181TASK DETAILhttps://phabricator.wikimedia.org/T205301EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/
gerritbot added a comment.
Change 463181 had a related patch set uploaded (by Smalyshev; owner: Smalyshev):
[mediawiki/extensions/WikimediaEvents@master] Ignore clicks with empty search string
https://gerrit.wikimedia.org/r/463181TASK DETAILhttps://phabricator.wikimedia.org/T205301EMAIL PREFERENCE
Smalyshev added a comment.
The empty items seem to be from property suggestions mechanism. The property suggestions API offers some properties even before the user typed anything. We should ignore such clicks.TASK DETAILhttps://phabricator.wikimedia.org/T205301EMAIL PREFERENCEShttps://phabricator.w
