Stashbot added a comment.
Mentioned in SAL (#wikimedia-operations) [2018-12-13T00:52:48Z] Synchronized php-1.33.0-wmf.8/includes/http/GuzzleHttpRequest.php: T211806 (duration: 00m 51s)TASK DETAILhttps://phabricator.wikimedia.org/T211806EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/pa
gerritbot added a comment.
Change 479362 merged by jenkins-bot:
[mediawiki/core@wmf/1.33.0-wmf.8] Fix guzzle InvalidArgumentException when body is passed as an array
https://gerrit.wikimedia.org/r/479362TASK DETAILhttps://phabricator.wikimedia.org/T211806EMAIL PREFERENCEShttps://phabricator.wikime
gerritbot added a comment.
Change 479359 merged by jenkins-bot:
[mediawiki/core@master] Fix guzzle InvalidArgumentException when body is passed as an array
https://gerrit.wikimedia.org/r/479359TASK DETAILhttps://phabricator.wikimedia.org/T211806EMAIL PREFERENCEShttps://phabricator.wikimedia.org/se
gerritbot added a comment.
Change 479362 had a related patch set uploaded (by Reedy; owner: BPirkle):
[mediawiki/core@wmf/1.33.0-wmf.8] Fix guzzle InvalidArgumentException when body is passed as an array
https://gerrit.wikimedia.org/r/479362TASK DETAILhttps://phabricator.wikimedia.org/T211806EMAIL
gerritbot added a comment.
Change 479359 had a related patch set uploaded (by BPirkle; owner: BPirkle):
[mediawiki/core@master] Fix guzzle InvalidArgumentException when body is passed as an array
https://gerrit.wikimedia.org/r/479359TASK DETAILhttps://phabricator.wikimedia.org/T211806EMAIL PREFERE
BPirkle added a comment.
This looks more promising:
if ( is_array( $postData ) ) {
$this->guzzleOptions['form_params'] = $postData;
} else {
$this->guzzleOptions['body'] = $postData;
}
Per http://docs.guzzlephp.org/en/stable/quickstart.html, Guzzle will automatically set Content
BPirkle added a comment.
Reproduced the exception locally using trivial test data:
$params = [ 'foo' => 'bar' ];
$response = Http::post(
'http://www.example.net',
[ 'postData' => $params ]
);
Then confirmed the exception disappeared per the suggestion from stack overflow, by adding this to Guzz
BPirkle added a comment.
GuzzleHttpRequest.php line 94, we are indeed setting the 'body' field and trusting that $postData was happily passed to the constructor by calling code. Fiddling...TASK DETAILhttps://phabricator.wikimedia.org/T211806EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settin
Reedy added a comment.
https://stackoverflow.com/a/38060763 seems very likely as to what's going on, especially as we're doing json stuff in jsonconfig (well, duh)
Note in Guzzle V6.0+, another source of getting the following error may be incorrect use of JSON as an array:
Passing in the "body" re
zeljkofilipin added a comment.
Do you have an estimate on the numbers when move group2 to wmf.8? If you estimate that the number will remain low, then I guess this is not blocking the train. If you don't have an estimate, I would be reluctant to move the train forward and this would still block the
Reedy added a comment.
84 in the last hour... I don't think this is unbreak now, but is probably at least HighTASK DETAILhttps://phabricator.wikimedia.org/T211806EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: ReedyCc: Legoktm, Reedy, BPirkle, Aklapper, TerraC
11 matches
Mail list logo
