[Wikidata-bugs] [Maniphest] [Commented On] T213889: WDQS UI fails on large queries

2019-03-05 Thread gerritbot
gerritbot added a comment. Change 494376 abandoned by Smalyshev: Merging from e9f3dd43523caa0878ca01f21b1e431c0b4b70be : Reason: superceded https://gerrit.wikimedia.org/r/494376 TASK DETAIL https:

[Wikidata-bugs] [Maniphest] [Commented On] T213889: WDQS UI fails on large queries

2019-03-04 Thread gerritbot
gerritbot added a comment. Change 494282 **merged** by jenkins-bot: [wikidata/query/gui@master] Retry queries with POST if server indicates request was too large https://gerrit.wikimedia.org/r/494282 TASK DETAIL https://phabricator.wikimedia.org/T213889 EMAIL PREFERENCES https://p

[Wikidata-bugs] [Maniphest] [Commented On] T213889: WDQS UI fails on large queries

2019-03-04 Thread gerritbot
gerritbot added a comment. Change 494282 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [wikidata/query/gui@master] Retry queries with POST if server indicates request was too large https://gerrit.wikimedia.org/r/494282 TASK DETAIL h

[Wikidata-bugs] [Maniphest] [Commented On] T213889: WDQS UI fails on large queries

2019-01-17 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. Yeah, the existing code only detects when the browser doesn’t send a request at all, so I guess there must now be some length that the browser still sends but the server rejects. This would of course be easier to debug if the reporting user on Wikidata provi

[Wikidata-bugs] [Maniphest] [Commented On] T213889: WDQS UI fails on large queries

2019-01-16 Thread Smalyshev
Smalyshev added a comment. I see the code is: if ( request.getAllResponseHeaders() === '' ) { // query might have been too long for GET, retry with POST settings.method = 'POST'; $.ajax( self._serviceUri, settings ).done( done ).fail( fail ); } I suspect when the server rejects it, the head

[Wikidata-bugs] [Maniphest] [Commented On] T213889: WDQS UI fails on large queries

2019-01-16 Thread Smalyshev
Smalyshev added a comment. Well, maybe there's some gap between client-side and server-side limits?TASK DETAILhttps://phabricator.wikimedia.org/T213889EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: SmalyshevCc: Lucas_Werkmeister_WMDE, Aklapper, Smalyshev, Nan

[Wikidata-bugs] [Maniphest] [Commented On] T213889: WDQS UI fails on large queries

2019-01-16 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. This was implemented long ago (apparently without a Phabricator task, but see Ic770e25bb4 and Ic3ea53c50e), but I guess something is behaving differently now? I don’t recall seeing an HTTP 414 error back then, the request just wouldn’t be sent at all (client-