[Wikidata-bugs] [Maniphest] [Commented On] T217770: [Story] Never show anything from a language that is not currently Wikidata conform

2020-01-07 Thread Addshore
Addshore added a comment. Removed from the campsite as we determined this is no longer a priority and we will finish wb_terms things as a top priority. TASK DETAIL https://phabricator.wikimedia.org/T217770 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreference

[Wikidata-bugs] [Maniphest] [Commented On] T217770: [Story] Never show anything from a language that is not currently Wikidata conform

2019-08-26 Thread Petar.petkovic
Petar.petkovic added a comment. I confirm that adding new labels for Serbian is possible again. Like I wrote earlier, one needs to have `sr` in their list of previous ULS languages. TASK DETAIL https://phabricator.wikimedia.org/T217770 EMAIL PREFERENCES https://phabricator.wikimedia.org/

[Wikidata-bugs] [Maniphest] [Commented On] T217770: [Story] Never show anything from a language that is not currently Wikidata conform

2019-08-26 Thread Stashbot
Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2019-08-26T11:34:25Z] Synchronized php-1.34.0-wmf.19/extensions/UniversalLanguageSelector: SWAT: [[gerrit:532341|Revert "Return target of redirect languages in mw.uls.getFrequentLanguageList" (T217770

[Wikidata-bugs] [Maniphest] [Commented On] T217770: [Story] Never show anything from a language that is not currently Wikidata conform

2019-08-26 Thread gerritbot
gerritbot added a comment. Change 532341 **merged** by jenkins-bot: [mediawiki/extensions/UniversalLanguageSelector@wmf/1.34.0-wmf.19] Revert "Return target of redirect languages in mw.uls.getFrequentLanguageList" https://gerrit.wikimedia.org/r/532341 TASK DETAIL https://phabricator.

[Wikidata-bugs] [Maniphest] [Commented On] T217770: [Story] Never show anything from a language that is not currently Wikidata conform

2019-08-26 Thread alaa_wmde
alaa_wmde added a comment. We will backport the merged revert in today's SWAT https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20190826T1100 TASK DETAIL https://phabricator.wikimedia.org/T217770 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailprefere

[Wikidata-bugs] [Maniphest] [Commented On] T217770: [Story] Never show anything from a language that is not currently Wikidata conform

2019-08-26 Thread gerritbot
gerritbot added a comment. Change 532341 had a related patch set uploaded (by Alaa Sarhan; owner: Ladsgroup): [mediawiki/extensions/UniversalLanguageSelector@wmf/1.34.0-wmf.19] Revert "Return target of redirect languages in mw.uls.getFrequentLanguageList" https://gerrit.wikimedia.org/r

[Wikidata-bugs] [Maniphest] [Commented On] T217770: [Story] Never show anything from a language that is not currently Wikidata conform

2019-08-25 Thread gerritbot
gerritbot added a comment. Change 532276 **merged** by jenkins-bot: [mediawiki/extensions/UniversalLanguageSelector@master] Revert "Return target of redirect languages in mw.uls.getFrequentLanguageList" https://gerrit.wikimedia.org/r/532276 TASK DETAIL https://phabricator.wikimedia.o

[Wikidata-bugs] [Maniphest] [Commented On] T217770: [Story] Never show anything from a language that is not currently Wikidata conform

2019-08-25 Thread gerritbot
gerritbot added a comment. Change 532276 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup): [mediawiki/extensions/UniversalLanguageSelector@master] Revert "Return target of redirect languages in mw.uls.getFrequentLanguageList" https://gerrit.wikimedia.org/r/532276 TASK

[Wikidata-bugs] [Maniphest] [Commented On] T217770: [Story] Never show anything from a language that is not currently Wikidata conform

2019-08-25 Thread Ladsgroup
Ladsgroup added a comment. I reverted the patch for now (not merged yet) TASK DETAIL https://phabricator.wikimedia.org/T217770 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup Cc: Petar.petkovic, alaa_wmde, Ladsgroup, Tarrow, Addshore, Ly

[Wikidata-bugs] [Maniphest] [Commented On] T217770: [Story] Never show anything from a language that is not currently Wikidata conform

2019-08-20 Thread Tarrow
Tarrow added a comment. Great! That's what we thought in the room. I guess there was and intention at task breakdown time of having other subtasks of this? e.g. to remove invalid languages from all the places with can think of if it doesn't come for free from what we do for termbox. e.g.

[Wikidata-bugs] [Maniphest] [Commented On] T217770: [Story] Never show anything from a language that is not currently Wikidata conform

2019-08-20 Thread WMDE-leszek
WMDE-leszek added a comment. Fair point, will adjust the description. In T217770#5425164 , @Tarrow wrote: > @WMDE-leszek just wanted to check that this story only applies to labels, descriptions and aliases. Only labels, descri

[Wikidata-bugs] [Maniphest] [Commented On] T217770: [Story] Never show anything from a language that is not currently Wikidata conform

2019-08-20 Thread Tarrow
Tarrow added a comment. @WMDE-leszek just wanted to check that this story only applies to labels, descriptions and aliases. Or do we also need to do something for monolingual texts in invalid languages? What about Lexemes or EntitySchemas? TASK DETAIL https://phabricator.wikimedia.or

[Wikidata-bugs] [Maniphest] [Commented On] T217770: [Story] Never show anything from a language that is not currently Wikidata conform

2019-08-20 Thread WMDE-leszek
WMDE-leszek added a comment. In T217770#5424750 , @Tarrow wrote: > We just spoke in the office and it seems that the decision (as I heard it from @WMDE-leszek and @Lea_WMDE) is to remove currently invalid language even from historic rev

[Wikidata-bugs] [Maniphest] [Commented On] T217770: [Story] Never show anything from a language that is not currently Wikidata conform

2019-08-20 Thread Tarrow
Tarrow added a comment. We just spoke in the office and it seems that the decision (as I heard it from @WMDE-leszek and @Lea_WMDE) is to remove currently invalid language even from historic revisions. We won't change the database but we will stop showing any invalid language. e.g. from API r

[Wikidata-bugs] [Maniphest] [Commented On] T217770: [Story] Never show anything from a language that is not currently Wikidata conform

2019-08-12 Thread alaa_wmde
alaa_wmde added a comment. @WMDE-leszek 100% agree. I actually was just asking out of curiosity (that that small change would fix the issues mentioned here). We should definitely go down the route of having Wikibase allow to manage a layer of supported languages on top of languages providers

[Wikidata-bugs] [Maniphest] [Commented On] T217770: [Story] Never show anything from a language that is not currently Wikidata conform

2019-08-10 Thread Lydia_Pintscher
Lydia_Pintscher added a comment. @Addshore agreed that we should ultimately not hide data in older revisions. There is T225789 for handling that behavior based on what @Lea_WMDE and I discussed. TASK DETAIL https://phabricator.wikimedia.org/T2177

[Wikidata-bugs] [Maniphest] [Commented On] T217770: [Story] Never show anything from a language that is not currently Wikidata conform

2019-07-25 Thread WMDE-leszek
WMDE-leszek added a comment. My two cents to the recent discussion: 1. The change https://gerrit.wikimedia.org/r/523176 is interesting, in particular the fact it has been accepted by ULS maintainers. In T222790 we've been asking them if the "ol

[Wikidata-bugs] [Maniphest] [Commented On] T217770: [Story] Never show anything from a language that is not currently Wikidata conform

2019-07-25 Thread Tarrow
Tarrow added a comment. > 2. When data load from the storage contains entries using a language code that is not recognized by Wikibase, those entries must not be presented to the user (e.g. for reason X there a label related to the invalid language code stored in the DB, I seem to reme

[Wikidata-bugs] [Maniphest] [Commented On] T217770: [Story] Never show anything from a language that is not currently Wikidata conform

2019-07-22 Thread Ladsgroup
Ladsgroup added a comment. In T217770#5352561 , @alaa_wmde wrote: > @Ladsgroup does the ULS fix alone enough for this task? if yes, should we move this to test/verify. if no, should we move it to ready to pick up (in case no one will be