[Wikidata-bugs] [Maniphest] [Commented On] T218191: Long score overlaps with statement box and edit button

alaa_wmde added a comment. Since this task seem to have fixed the issue for new scores, and old ones except https://www.wikidata.org/wiki/Q11980 (are there any others? is there a way to check that even?), I'd like to close this task. If that's fine by you @Ebe123, I'd first create a

[Wikidata-bugs] [Maniphest] [Commented On] T218191: Long score overlaps with statement box and edit button

Ebe123 added a comment. Sorry, I have been looking as to why the cache bumping does not work, as it should be part of the hash. I have not determined why it fails. For Q11980, I added a useless character to re-generate the image, although that shouldn't be necessary. TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T218191: Long score overlaps with statement box and edit button

WMDE-leszek added a comment. Pinging @Ebe123, did you have chance to look into the issue described above (i.e. T218191#5180154 )? It's been a while since the cache version has been bumped, but the score still does look wrong on

[Wikidata-bugs] [Maniphest] [Commented On] T218191: Long score overlaps with statement box and edit button

Lucas_Werkmeister_WMDE added a comment. @Ebe123 the `CACHE_VERSION` bump was merged and should have been deployed for a while now, but purging Q11980 from the parser cache (I tried both `action=purge` and `purgePage.php`) doesn’t seem to fix the issue.

[Wikidata-bugs] [Maniphest] [Commented On] T218191: Long score overlaps with statement box and edit button

noarave added a comment. After https://gerrit.wikimedia.org/r/504931 is deployed, purge cached pages containing Musical Notations TASK DETAIL https://phabricator.wikimedia.org/T218191 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: alaa_wmde,

[Wikidata-bugs] [Maniphest] [Commented On] T218191: Long score overlaps with statement box and edit button

gerritbot added a comment. Change 504931 **merged** by jenkins-bot: [mediawiki/extensions/Score@master] Invalidate score cache https://gerrit.wikimedia.org/r/504931 TASK DETAIL https://phabricator.wikimedia.org/T218191 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T218191: Long score overlaps with statement box and edit button

gerritbot added a comment. Change 504931 had a related patch set uploaded (by Ebe123; owner: Ebe123): [mediawiki/extensions/Score@master] Invalidate score cache https://gerrit.wikimedia.org/r/504931 TASK DETAIL https://phabricator.wikimedia.org/T218191 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T218191: Long score overlaps with statement box and edit button

Ebe123 added a comment. Yes, all scores can be purged by changing the `SCORE_CACHE`: https://phabricator.wikimedia.org/diffusion/ESCR/browse/master/includes/Score.php$40 TASK DETAIL https://phabricator.wikimedia.org/T218191 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T218191: Long score overlaps with statement box and edit button

Jc86035 added a comment. I think a complete reset could require looking at every diff as well, since I've definitely edited some of the relevant statements more than once. TASK DETAIL https://phabricator.wikimedia.org/T218191 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T218191: Long score overlaps with statement box and edit button

Lucas_Werkmeister_WMDE added a comment. Might be worth wrapping this up in a maintenance script: - list all properties with “musical-notation” datatype - for each property, list all pages in entity namespaces that link to that property - for each page, find the image paths (ideally

[Wikidata-bugs] [Maniphest] [Commented On] T218191: Long score overlaps with statement box and edit button

Lucas_Werkmeister_WMDE added a comment. I was able to do it locally with the following code: $b = Score::getBackend(); $imagePath = 'c/u/cuyqryp5dkc9pf7nytn4wve93hwed0a/cuyqryp5.png'; // this will vary by image, of course $b->delete( [ 'src' => $b->getRootStoragePath() .

[Wikidata-bugs] [Maniphest] [Commented On] T218191: Long score overlaps with statement box and edit button

Jc86035 added a comment. Also, it seems that if you change it back to the original, the old thumbnail is reused. Is there a way to reset all of Wikidata's LilyPond images? TASK DETAIL https://phabricator.wikimedia.org/T218191 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T218191: Long score overlaps with statement box and edit button

Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2019-04-16T11:18:09Z] Synchronized wmf-config/InitialiseSettings.php: Add wgWikibaseMusicalNotationLineWidthInches to config (T218191 ) (duration: 00m 52s) TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T218191: Long score overlaps with statement box and edit button

gerritbot added a comment. Change 498661 **merged** by jenkins-bot: [operations/mediawiki-config@master] Add wgWikibaseMusicalNotationLineWidthInches to config https://gerrit.wikimedia.org/r/498661 TASK DETAIL https://phabricator.wikimedia.org/T218191 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T218191: Long score overlaps with statement box and edit button

alaa_wmde added a comment. planned to deploy this in the mid-day swat today TASK DETAIL https://phabricator.wikimedia.org/T218191 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: alaa_wmde Cc: Ebe123, TheDJ, Jc86035, Aklapper,

[Wikidata-bugs] [Maniphest] [Commented On] T218191: Long score overlaps with statement box and edit button

gerritbot added a comment. Change 498660 **merged** by jenkins-bot: [operations/mediawiki-config@master] Add wgWikibaseMusicalNotationLineWidthInches to labs config https://gerrit.wikimedia.org/r/498660 TASK DETAIL https://phabricator.wikimedia.org/T218191 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T218191: Long score overlaps with statement box and edit button

gerritbot added a comment. Change 498094 **merged** by jenkins-bot: [mediawiki/extensions/Score@master] shorten score line width on wikidata https://gerrit.wikimedia.org/r/498094 TASK DETAIL https://phabricator.wikimedia.org/T218191 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T218191: Long score overlaps with statement box and edit button

alaa_wmde added a comment. Yeap I can make both in ~3h for sure.. won't include much refactoring then but can be done.. lemme try TASK DETAIL https://phabricator.wikimedia.org/T218191 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: alaa_wmde Cc:

[Wikidata-bugs] [Maniphest] [Commented On] T218191: Long score overlaps with statement box and edit button

Lydia_Pintscher added a comment. Yeah so ideally we have one width for statements on entities and another width for everything else on Wikidata. If this is more than say 3h of work then it's probably not justified spending time on that part atm though. In this case I'd set everything to the

[Wikidata-bugs] [Maniphest] [Commented On] T218191: Long score overlaps with statement box and edit button

Lucas_Werkmeister_WMDE added a comment. Okay, apparently you can find scores with Special:PagesWithProp/score . Not that many uses at the moment. TASK DETAIL https://phabricator.wikimedia.org/T218191 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T218191: Long score overlaps with statement box and edit button

Lucas_Werkmeister_WMDE added a comment. > configure the line width using a configuration variable `wgScoreLineWidthInches` that sounds like it will also affect scores on the same wiki outside of statements :/ TASK DETAIL https://phabricator.wikimedia.org/T218191 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T218191: Long score overlaps with statement box and edit button

gerritbot added a comment. Change 498661 had a related patch set uploaded (by Alaa Sarhan; owner: Alaa Sarhan): [operations/mediawiki-config@master] Add wgScoreLineWidthInches to config https://gerrit.wikimedia.org/r/498661 TASK DETAIL https://phabricator.wikimedia.org/T218191

[Wikidata-bugs] [Maniphest] [Commented On] T218191: Long score overlaps with statement box and edit button

gerritbot added a comment. Change 498660 had a related patch set uploaded (by Alaa Sarhan; owner: Alaa Sarhan): [operations/mediawiki-config@master] Add wgScoreLineWidthInches to labs config https://gerrit.wikimedia.org/r/498660 TASK DETAIL https://phabricator.wikimedia.org/T218191

[Wikidata-bugs] [Maniphest] [Commented On] T218191: Long score overlaps with statement box and edit button

gerritbot added a comment. Change 498094 had a related patch set uploaded (by Alaa Sarhan; owner: Alaa Sarhan): [mediawiki/extensions/Score@master] shorten score line width on wikidata https://gerrit.wikimedia.org/r/498094 TASK DETAIL https://phabricator.wikimedia.org/T218191 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T218191: Long score overlaps with statement box and edit button

TheDJ added a comment. .wikibase-snakview-value .mw-ext-score { max-width: 100%; overflow-x: auto; } In Minerva, this is the noresize rule

[Wikidata-bugs] [Maniphest] [Commented On] T218191: Long score overlaps with statement box and edit button

Lucas_Werkmeister_WMDE added a comment. @TheDJ I’m not sure exactly what CSS you mean, but `overflow-x: auto` on its own doesn’t seem to do anything on my system, and in combination with `max-width: 100%` it only scales one axis, distorting the aspect ratio. TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T218191: Long score overlaps with statement box and edit button

TheDJ added a comment. .wikibase-snakview-value .mw-ext-score img { max-width: 100%; object-fit: scale-down; } or use overflow-x: auto, like mobile site does when content is too big and it cannot be sure it is easily resizable. TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T218191: Long score overlaps with statement box and edit button

Jc86035 added a comment. Considering that the mobile site has a column width of 280px for `wikibase-statementgrouplistview` and the desktop site's `wikibase-snakview-body` is 417px wide at maximum, using a zoom as well as a page size might be appropriate. (Alternately, the mobile site could

[Wikidata-bugs] [Maniphest] [Commented On] T218191: Long score overlaps with statement box and edit button

Jc86035 added a comment. I've tried testing the scores from the linked Wikipedia article at Q405798 on beta . The page resizing seems to work, although a different size might be better. The code of the last score (which I modified slightly to

[Wikidata-bugs] [Maniphest] [Commented On] T218191: Long score overlaps with statement box and edit button

Lucas_Werkmeister_WMDE added a comment. A possible CSS workaround: .wikibase-snakview-value .mw-ext-score img { max-width: 100%; object-fit: scale-down; } But depending on how much scaling is necessary, this can make the score unreadable, so a solution at the

[Wikidata-bugs] [Maniphest] [Commented On] T218191: Long score overlaps with statement box and edit button

Jc86035 added a comment. The only way I know of making the score narrower is to set the page size. TASK DETAIL https://phabricator.wikimedia.org/T218191 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jc86035 Cc: Jc86035, Aklapper,