[Wikidata-bugs] [Maniphest] [Commented On] T220904: Empty edits in edit history

gerritbot added a comment. Change 507027 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Don't allow edits with equal content https://gerrit.wikimedia.org/r/507027 TASK DETAIL https://phabricator.wikimedia.org/T220904 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T220904: Empty edits in edit history

gerritbot added a comment. Change 507027 had a related patch set uploaded (by Hoo man; owner: Hoo man): [mediawiki/extensions/Wikibase@master] Don't allow edits with equal content https://gerrit.wikimedia.org/r/507027 TASK DETAIL https://phabricator.wikimedia.org/T220904 EMAIL

[Wikidata-bugs] [Maniphest] [Commented On] T220904: Empty edits in edit history

Ladsgroup added a comment. In T220904#5143035 , @Michael wrote: > That is the reason I've been trying to get the DB contents directly. Is there a practical way to get the DB's contents as in P8452

[Wikidata-bugs] [Maniphest] [Commented On] T220904: Empty edits in edit history

Michael added a comment. In T220904#5142888 , @hoo wrote: > But please notice that we transform the JSON before passing it to the API, thus what you get there is not what's actually in the DB. That is the reason I've been trying

[Wikidata-bugs] [Maniphest] [Commented On] T220904: Empty edits in edit history

Michael added a comment. In T220904#5140806 , @hoo wrote: > I just checked this for the revisions 889025858 and 917938818. Both refer to equal content blobs (before and after inflating). > > [...] > > 2. (**SUPER UGLY**)

[Wikidata-bugs] [Maniphest] [Commented On] T220904: Empty edits in edit history

hoo added a comment. In T220904#5140840 , @daniel wrote: > > Change SlotRecord::hasSameContent to no longer take the size into account (given the other criteria checked in there, I guess this would be fine) > > Comparing the hash

[Wikidata-bugs] [Maniphest] [Commented On] T220904: Empty edits in edit history

Lucas_Werkmeister_WMDE added a comment. 3. Stop using `serialize` in `EntityContent::getSize()` and instead use e. g. `json_encode()`? TASK DETAIL https://phabricator.wikimedia.org/T220904 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: hoo,

[Wikidata-bugs] [Maniphest] [Commented On] T220904: Empty edits in edit history

daniel added a comment. > Change SlotRecord::hasSameContent to no longer take the size into account (given the other criteria checked in there, I guess this would be fine) Comparing the hash would be sufficient, but it's expensive if the hash isn't in the database (can't happen with the

[Wikidata-bugs] [Maniphest] [Commented On] T220904: Empty edits in edit history

Edoderoo added a comment. Thanks Michael. I have made two changes to my description-python-code ... one is the weird, and by intention broken link to the log, that is not updated for over a year anyways. I don't think that will be the cause, but I took that out now. Another change,

[Wikidata-bugs] [Maniphest] [Commented On] T220904: Empty edits in edit history

Michael added a comment. @Edoderoo I noticed that the log file linked in the edit summaries seems to be very outdated. Are there somewhere more up-to-date logs available? TASK DETAIL https://phabricator.wikimedia.org/T220904 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T220904: Empty edits in edit history

Edoderoo added a comment. Usually, a null edit (nothing changed) will result in that: a null edit with no history, and no edit on the account. For some reason, I sometimes run into null-edits that do leave a trace, for the moment I can not see why that does happen, to me it looks like a

[Wikidata-bugs] [Maniphest] [Commented On] T220904: Empty edits in edit history

Lydia_Pintscher added a comment. Yeah I am not sure what's happening. So I'd say let's stop the bot until either @Edoderoo or someone from the dev team can look into it. TASK DETAIL https://phabricator.wikimedia.org/T220904 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T220904: Empty edits in edit history

Bencemac added a comment. More and more . I fear I could easily find more of them. @Lydia_Pintscher; shall we do an emergency

[Wikidata-bugs] [Maniphest] [Commented On] T220904: Empty edits in edit history

Bencemac added a comment. One more example . TASK DETAIL https://phabricator.wikimedia.org/T220904 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Bencemac Cc: