gerritbot added a comment.
Change 560351 **merged** by jenkins-bot:
[mediawiki/extensions/UserMerge@master] Replace deprecated Title::moveTo with
MovePage method
https://gerrit.wikimedia.org/r/560351
TASK DETAIL
https://phabricator.wikimedia.org/T221949
EMAIL PREFERENCES
DannyS712 added a comment.
Yes, since `Title::moveTo` defaults to `$wgUser`, I left the behavior the
same by passing `$wgUser` for the move call.
TASK DETAIL
https://phabricator.wikimedia.org/T221949
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
Art-Baltai added a comment.
I close my patch
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UserMerge/+/566838
note about global var
https://3v4l.org/MpY9D
https://3v4l.org/hjYJo
--
https://phabricator.wikimedia.org/T221949
EMAIL PREFERENCES
gerritbot added a comment.
Change 566838 abandoned by Art-Baltai:
component: Refactofing of Title::moveTo to MovePageFactory->MovePage
Reason:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UserMerge/ /560351
https://gerrit.wikimedia.org/r/566838
TASK DETAIL
Art-Baltai added a comment.
Oh, sorry, @DannyS712 :)
We get the same code, so it looks correct.
Also, I added an example for global invoke
https://3v4l.org/MpY9D
https://3v4l.org/hjYJo
link is temporary
TASK DETAIL
https://phabricator.wikimedia.org/T221949
EMAIL PREFERENCES
gerritbot added a comment.
Change 566838 had a related patch set uploaded (by Art-Baltai; owner:
Art-Baltai):
[mediawiki/extensions/UserMerge@master] component: Refactofing of
Title::moveTo to MovePageFactory->MovePage
https://gerrit.wikimedia.org/r/566838
TASK DETAIL
daniel added a comment.
The sole remaining issue here is to add a test for UserMerge that tests the
page move, so we can merge the respective patch with confidence:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UserMerge/+/560351
TASK DETAIL
