[Wikidata-bugs] [Maniphest] [Commented On] T224607: CentralAuth, MassMessage and WikibaseLexeme build failures

gerritbot added a comment. Change 513250 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Tests: Reset PermissionManager service https://gerrit.wikimedia.org/r/513250 TASK DETAIL https://phabricator.wikimedia.org/T224607 EMAIL PREFERENCES https://phabricator

[Wikidata-bugs] [Maniphest] [Commented On] T224607: CentralAuth, MassMessage and WikibaseLexeme build failures

gerritbot added a comment. Change 513268 **merged** by jenkins-bot: [mediawiki/core@master] Reset services after setting group permissions in tests https://gerrit.wikimedia.org/r/513268 TASK DETAIL https://phabricator.wikimedia.org/T224607 EMAIL PREFERENCES https://phabricator.wik

[Wikidata-bugs] [Maniphest] [Commented On] T224607: CentralAuth, MassMessage and WikibaseLexeme build failures

daniel added a comment. @kostajh @WDoranWMF I'm here for another couple of hours today, and I'm also available on Monday. I think at least the first two patches can go in now: - https://gerrit.wikimedia.org/r/c/mediawiki/core/+/513268 - https://gerrit.wikimedia.org/r/c/mediawiki/extens

[Wikidata-bugs] [Maniphest] [Commented On] T224607: CentralAuth, MassMessage and WikibaseLexeme build failures

WDoranWMF added a comment. @kostajh Thank you so much. I'll sync with @daniel and make sure we're able to. TASK DETAIL https://phabricator.wikimedia.org/T224607 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: kostajh, WDoranWMF Cc: WDoranWMF, Tgr

[Wikidata-bugs] [Maniphest] [Commented On] T224607: CentralAuth, MassMessage and WikibaseLexeme build failures

kostajh added a comment. @WDoranWMF I've reviewed and can merge it if someone from CPT would be around to handle any breakages in extensions (see this comment ). TASK DETAIL https://phabrica

[Wikidata-bugs] [Maniphest] [Commented On] T224607: CentralAuth, MassMessage and WikibaseLexeme build failures

gerritbot added a comment. Change 513197 **merged** by jenkins-bot: [mediawiki/extensions/CentralAuth@master] Override MediaWikiServices so tests can pass https://gerrit.wikimedia.org/r/513197 TASK DETAIL https://phabricator.wikimedia.org/T224607 EMAIL PREFERENCES https://phabrica

[Wikidata-bugs] [Maniphest] [Commented On] T224607: CentralAuth, MassMessage and WikibaseLexeme build failures

gerritbot added a comment. Change 513248 **merged** by jenkins-bot: [mediawiki/extensions/MassMessage@master] Tests: Override MediaWiki Services https://gerrit.wikimedia.org/r/513248 TASK DETAIL https://phabricator.wikimedia.org/T224607 EMAIL PREFERENCES https://phabricator.wikimed

[Wikidata-bugs] [Maniphest] [Commented On] T224607: CentralAuth, MassMessage and WikibaseLexeme build failures

Vedmaka added a comment. In T224607#555 , @Umherirrender wrote: > MediaWikiTestCase::setGroupPermissions should override the services, not each extension calling that function or at least mention the fact, that it is needed.

[Wikidata-bugs] [Maniphest] [Commented On] T224607: CentralAuth, MassMessage and WikibaseLexeme build failures

gerritbot added a comment. Change 513283 abandoned by Kosta Harlan: Add CentralAuth, MassMessage and WikibaseLexeme to gated extensions https://gerrit.wikimedia.org/r/513283 TASK DETAIL https://phabricator.wikimedia.org/T224607 EMAIL PREFERENCES https://phabricator.wikimedia.org/se

[Wikidata-bugs] [Maniphest] [Commented On] T224607: CentralAuth, MassMessage and WikibaseLexeme build failures

gerritbot added a comment. Change 513283 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan): [integration/config@master] Add CentralAuth, MassMessage and WikibaseLexeme to gated extensions https://gerrit.wikimedia.org/r/513283 TASK DETAIL https://phabricator.wik

[Wikidata-bugs] [Maniphest] [Commented On] T224607: CentralAuth, MassMessage and WikibaseLexeme build failures

gerritbot added a comment. Change 513268 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler): [mediawiki/core@master] Reset services after setting group permissions in tests. https://gerrit.wikimedia.org/r/513268 TASK DETAIL https://phabricator.wikimedia.org/

[Wikidata-bugs] [Maniphest] [Commented On] T224607: CentralAuth, MassMessage and WikibaseLexeme build failures

daniel added a comment. In T224607#555 , @Umherirrender wrote: > MediaWikiTestCase::setGroupPermissions should override the services, not each extension calling that function or at least mention the fact, that it is needed.

[Wikidata-bugs] [Maniphest] [Commented On] T224607: CentralAuth, MassMessage and WikibaseLexeme build failures

gerritbot added a comment. Change 513250 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan): [mediawiki/extensions/WikibaseLexeme@master] Tests: Reset PermissionManager service https://gerrit.wikimedia.org/r/513250 TASK DETAIL https://phabricator.wikimedia.org/T

[Wikidata-bugs] [Maniphest] [Commented On] T224607: CentralAuth, MassMessage and WikibaseLexeme build failures

gerritbot added a comment. Change 513248 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan): [mediawiki/extensions/MassMessage@master] Tests: Override MediaWiki Services https://gerrit.wikimedia.org/r/513248 TASK DETAIL https://phabricator.wikimedia.org/T224607

[Wikidata-bugs] [Maniphest] [Commented On] T224607: CentralAuth, MassMessage and WikibaseLexeme build failures

Umherirrender added a comment. MediaWikiTestCase::setGroupPermissions should override the services, not each extension calling that function TASK DETAIL https://phabricator.wikimedia.org/T224607 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umh

[Wikidata-bugs] [Maniphest] [Commented On] T224607: CentralAuth, MassMessage and WikibaseLexeme build failures

gerritbot added a comment. Change 513197 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan): [mediawiki/extensions/CentralAuth@master] Override MediaWikiServices so tests can pass https://gerrit.wikimedia.org/r/513197 TASK DETAIL https://phabricator.wikimedia.or

[Wikidata-bugs] [Maniphest] [Commented On] T224607: CentralAuth, MassMessage and WikibaseLexeme build failures

kostajh added a comment. @Umherirrender the Depends-On references in that patch contain the hints about what needs to happen. I'll submit a fix now for CentralAuth. TASK DETAIL https://phabricator.wikimedia.org/T224607 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/em

[Wikidata-bugs] [Maniphest] [Commented On] T224607: CentralAuth, MassMessage and WikibaseLexeme build failures

kostajh added a comment. > So we have unexpected permissions errors and a fresh merged patch set about permissions - https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/502484/ Yeah I was just looking at it. That's the problematic commit. One commit prior to that, and CentralAuth tests w

[Wikidata-bugs] [Maniphest] [Commented On] T224607: CentralAuth, MassMessage and WikibaseLexeme build failures

kostajh added a comment. > When was the last passing build for this repo in Gerrit? I believe it was this patch , see here: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/513022#

[Wikidata-bugs] [Maniphest] [Commented On] T224607: CentralAuth, MassMessage and WikibaseLexeme build failures

Krinkle added a comment. @kostajh To confirm, the build is passing for core, CentralAuth, MassMessage and WikibaseLexeme. But the build is failing for commits to GrowthExperiments, for which these gates tests also run. Is that right? I don't see any changes in `core:/includes/api` last 2