[Wikidata-bugs] [Maniphest] [Commented On] T226264: Recommendation-API CI testing is flaky due to frequent 429s from Wikidata Query Service

2019-06-21 Thread gerritbot
gerritbot added a comment. Change 518349 **merged** by jenkins-bot: [mediawiki/services/recommendation-api@master] Temporarily disable flaky tests https://gerrit.wikimedia.org/r/518349 TASK DETAIL https://phabricator.wikimedia.org/T226264 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T226264: Recommendation-API CI testing is flaky due to frequent 429s from Wikidata Query Service

2019-06-21 Thread gerritbot
gerritbot added a comment. Change 518349 had a related patch set uploaded (by Bmansurov; owner: Bmansurov): [mediawiki/services/recommendation-api@master] Temporarily disable flaky tests https://gerrit.wikimedia.org/r/518349 TASK DETAIL https://phabricator.wikimedia.org/T226264

[Wikidata-bugs] [Maniphest] [Commented On] T226264: Recommendation-API CI testing is flaky due to frequent 429s from Wikidata Query Service

2019-06-21 Thread Mholloway
Mholloway added a comment. Hmm, now that I'm digging, I see that the batching was just introduced: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/services/recommendation-api/+/9603d4282492103eecc0b1646ea2911138c848af%5E%21/lib/article.creation.translation.js TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T226264: Recommendation-API CI testing is flaky due to frequent 429s from Wikidata Query Service

2019-06-21 Thread Mholloway
Mholloway added a comment. Sure. The specific URL that the flaky test is hitting is https://de.wikipedia.org/api/rest_v1/data/recommendation/article/creation/translation/en. Under the hood, the service is querying WDQS with this up to 10 times in rapid succession, for a batched set of

[Wikidata-bugs] [Maniphest] [Commented On] T226264: Recommendation-API CI testing is flaky due to frequent 429s from Wikidata Query Service

2019-06-21 Thread Smalyshev
Smalyshev added a comment. Could you give some details on what recommendation API is actually doing there? Maybe post a link to the relevant code and probably explanation of which queries it is running and how often? Generally 429 means it is sending too many queries too often. Which