gerritbot added a comment.
Change 571534 **merged** by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Revert "Introduce
ContentLanguagesFallbackChainFilterer"
https://gerrit.wikimedia.org/r/571534
TASK DETAIL
https://phabricator.wikimedia.org/T227083
EMAIL PREFERENCES
https:/
Tarrow added a comment.
I saw this revert patch come up; it's a great idea to clean up if not needed.
I see the ticket is closed but as far as I can see unsupported language can
still appear in the termbox in various cases.
See for example
https://wikidata.beta.wmflabs.org/wiki/Q112?u
gerritbot added a comment.
Change 571534 had a related patch set uploaded (by Lucas Werkmeister (WMDE);
owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Revert "Introduce
ContentLanguagesFallbackChainFilterer"
https://gerrit.wikimedia.org/r/571534
TASK DETAIL
gerritbot added a comment.
Change 554835 **merged** by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Filter out invalid term languages from
termbox
https://gerrit.wikimedia.org/r/554835
TASK DETAIL
https://phabricator.wikimedia.org/T227083
EMAIL PREFERENCES
https://phabricat
gerritbot added a comment.
Change 533941 abandoned by Addshore:
FingerprintableEntityMetaTagsCreator gets just Term Languages
Reason:
Abandoned in favour of
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/ /554835/
https://gerrit.wikimedia.org/r/533941
TASK DETA
gerritbot added a comment.
Change 534534 abandoned by Addshore:
Add TermsContentLanguages to JS config
Reason:
Abandoned in favour of
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/ /554835/
https://gerrit.wikimedia.org/r/534534
TASK DETAIL
https://phabricato
gerritbot added a comment.
Change 533913 abandoned by Addshore:
Use only Terms languages in EntityTermsViews FallbackChains
Reason:
Abandoned in favour of
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/ /554835/
https://gerrit.wikimedia.org/r/533913
TASK DETAIL
gerritbot added a comment.
Change 554537 abandoned by Addshore:
Filter out invalid term languages from termbox
Reason:
Abandoned in favour of
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/ /554835/
https://gerrit.wikimedia.org/r/554537
TASK DETAIL
https://ph
gerritbot added a comment.
Change 554835 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Filter out invalid term languages from
termbox
https://gerrit.wikimedia.org/r/554835
TASK DETAIL
https://phabricator.wikimedia.org/T227083
EMAIL
gerritbot added a comment.
Change 554537 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Filter out invalid term languages from
termbox
https://gerrit.wikimedia.org/r/554537
TASK DETAIL
https://phabricator.wikimedia.org/T227083
EMAIL
gerritbot added a comment.
Change 534534 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Wikibase@master] Add TermsContentLanguages to JS config
https://gerrit.wikimedia.org/r/534534
TASK DETAIL
https://phabricator.wikimedia.org/T227083
EMAIL PREFER
gerritbot added a comment.
Change 531938 **merged** by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Wire up
UserPreferredContentLanguagesLookup with OutputPageBeforeHTMLHookHandler
https://gerrit.wikimedia.org/r/531938
TASK DETAIL
https://phabricator.wikimedia.org/T227083
EMA
gerritbot added a comment.
Change 533497 **merged** by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Introduce
ContentLanguagesFallbackChainFilterer
https://gerrit.wikimedia.org/r/533497
TASK DETAIL
https://phabricator.wikimedia.org/T227083
EMAIL PREFERENCES
https://phabrica
gerritbot added a comment.
Change 532708 **merged** by jenkins-bot:
[mediawiki/extensions/Wikibase@master] UserPreferredContentLanguagesLookup:
better method param name
https://gerrit.wikimedia.org/r/532708
TASK DETAIL
https://phabricator.wikimedia.org/T227083
EMAIL PREFERENCES
ht
gerritbot added a comment.
Change 533941 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Wikibase@master] FingerprintableEntityMetaTagsCreator
gets just Term Languages
https://gerrit.wikimedia.org/r/533941
TASK DETAIL
https://phabricator.wikimedia.o
gerritbot added a comment.
Change 533183 abandoned by Tarrow:
Ensure EntityTermsViewFactory builds with valid Terms Languages
Reason:
It seems that useful bit of this patch has been supplanted by:
I79f735c7a07760bd1a85c9e39bed5168d2092390
https://gerrit.wikimedia.org/r/533183
TA
gerritbot added a comment.
Change 533913 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Wikibase@master] Use only Terms languages in
EntityTermsViews FallbackChains
https://gerrit.wikimedia.org/r/533913
TASK DETAIL
https://phabricator.wikimedia.org
gerritbot added a comment.
Change 533497 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Wikibase@master] Introduce
ContentLanguagesFallbackChainFilterer
https://gerrit.wikimedia.org/r/533497
TASK DETAIL
https://phabricator.wikimedia.org/T227083
EM
gerritbot added a comment.
Change 533183 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Wikibase@master] Ensure EntityTermsViewFactory builds
with valid Terms Languages
https://gerrit.wikimedia.org/r/533183
TASK DETAIL
https://phabricator.wikimedia
gerritbot added a comment.
Change 532708 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] UserPreferredContentLanguagesLookup:
better method param name
https://gerrit.wikimedia.org/r/532708
TASK DETAIL
https://phabricator.wikimedia.org
gerritbot added a comment.
Change 531924 **merged** by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add service for looking up a user's
preferred languages
https://gerrit.wikimedia.org/r/531924
TASK DETAIL
https://phabricator.wikimedia.org/T227083
EMAIL PREFERENCES
https://
gerritbot added a comment.
Change 531938 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Wire up
UserPreferredContentLanguagesLookup with OutputPageBeforeHTMLHookHandler
https://gerrit.wikimedia.org/r/531938
TASK DETAIL
https://phabri
gerritbot added a comment.
Change 531924 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/Wikibase@master] Add service for looking up a user's
preferred languages
https://gerrit.wikimedia.org/r/531924
TASK DETAIL
https://phabricator.wikimedia.org/T2270
Tarrow added a comment.
Looks like that is partially true. I also missed that due to
extensions/Wikibase/repo/includes/Hooks/OutputPageBeforeHTMLHookHandler.php:274
the language of the OutputPage is also always included even if it is not valid.
This is then used to generate the language for
Tarrow added a comment.
For the current desktop termbox it appears that we already check when
building the termbox with the user's language that all of those languages are
valid WikibaseContent languages:
Non-valid language are filtered out here:
extensions/Wikibase/repo/includes/Hooks/
25 matches
Mail list logo
