[Wikidata-bugs] [Maniphest] [Commented On] T227847: Backfill terms index

2019-07-21 Thread Addshore
Addshore added a comment. > Also why captions even matter for T223792 - shouldn't getEntity look up by ID (which in case of MediaInfo is straight page id) not by caption? Indeed, if we are not trying to lookup by caption, but only by ID then

[Wikidata-bugs] [Maniphest] [Commented On] T227847: Backfill terms index

2019-07-18 Thread Smalyshev
Smalyshev added a comment. > you'll see it's just labels Yes and no. They are stored in labels slot, but that doesn't mean they are the same in all aspects. E.g. labels are used to look up items all the time, but would captions be used to look up files? I don't think they'd be used the

[Wikidata-bugs] [Maniphest] [Commented On] T227847: Backfill terms index

2019-07-18 Thread Multichill
Multichill added a comment. In T227847#5343076 , @Addshore wrote: > The re design for items and properties gas already happened. > Mediainfo could benefit from a different design if there are only captions. > Are there only captions?

[Wikidata-bugs] [Maniphest] [Commented On] T227847: Backfill terms index

2019-07-18 Thread Addshore
Addshore added a comment. If elastic already has captions indexed then yes this could probably just use elastic. (There would be slightly more delay and potential unpredictability using elastic than some mysql tables like wb_terms). However I would be wary, as we have before discussed

[Wikidata-bugs] [Maniphest] [Commented On] T227847: Backfill terms index

2019-07-18 Thread Smalyshev
Smalyshev added a comment. What kind of lookups there should be for MediaInfo - can ElasticSearch index that we already have be used for it? TASK DETAIL https://phabricator.wikimedia.org/T227847 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To:

[Wikidata-bugs] [Maniphest] [Commented On] T227847: Backfill terms index

2019-07-17 Thread Addshore
Addshore added a comment. The re design for items and properties gas already happened. Mediainfo could benefit from a different design if there are only captions. Are there only captions? Are they unique to a media info entity? How long can they be? Will the use of this index only

[Wikidata-bugs] [Maniphest] [Commented On] T227847: Backfill terms index

2019-07-17 Thread Abit
Abit added a comment. @alaa_wmde , as @Lucas_Werkmeister_WMDE says, we do indeed have a clear use case for MediaInfo now--we need to be able to find the M entity that is added to lua syntax on Commons. Can you please include this use case in your redesign? TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T227847: Backfill terms index

2019-07-16 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. Well, it sounds like the need has arisen already (T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items ). TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T227847: Backfill terms index

2019-07-16 Thread alaa_wmde
alaa_wmde added a comment. > When designing new system, I pushed to add support of mediainfo in the new system too but I don't think that passed through. @alaa_wmde knows better. Yeap we will not support other entity types at the moment. When the need arises we will consider the

[Wikidata-bugs] [Maniphest] [Commented On] T227847: Backfill terms index

2019-07-12 Thread alaa_wmde
alaa_wmde added a comment. @matthiasmullie okay now I have got to T227848: [Spike 1 day] Figure out wb_terms redesign, and what that means for MediaInfo and understand the context. I'll reply on that task. TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T227847: Backfill terms index

2019-07-12 Thread Cparle
Cparle added a comment. I thought the `wb_terms` table was being deprecated ... hmmm, maybe I'm mixing it up with something else TASK DETAIL https://phabricator.wikimedia.org/T227847 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Cparle Cc: