[Wikidata-bugs] [Maniphest] [Commented On] T229390: Debug parameter causes crashes

2019-08-01 Thread gerritbot
gerritbot added a comment. Change 527072 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Wrap Vue2 JS file in IIFE https://gerrit.wikimedia.org/r/527072 TASK DETAIL https://phabricator.wikimedia.org/T229390 EMAIL PREFERENCES https://phabricator.wikimedia.org/setti

[Wikidata-bugs] [Maniphest] [Commented On] T229390: Debug parameter causes crashes

2019-08-01 Thread gerritbot
gerritbot added a comment. Change 527072 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/Wikibase@master] Wrap Vue2 JS file in IIFE https://gerrit.wikimedia.org/r/527072 TASK DETAIL https://phabricator.wikimedia.o

[Wikidata-bugs] [Maniphest] [Commented On] T229390: Debug parameter causes crashes

2019-08-01 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. > However, it is not clear why this should make a difference as our code is not supposed to modify `$`, even when called in the global scope. Well, our own code doesn’t modify it, but `vue2.common.prod.js` does. name=vue2.common.prod.js (unmini

[Wikidata-bugs] [Maniphest] [Commented On] T229390: Debug parameter causes crashes

2019-07-31 Thread Michael
Michael added a comment. Results of my investigation so far: These errors are triggered by line https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/c8fbefa4fd9ce869ffd228ac1fe236c54fdb78bf/client/data-bridge/src/mediawiki/init.ts#L24: const require = await mwWindow.mw.l