[Wikidata-bugs] [Maniphest] [Commented On] T233520: page_props wikibase_item is sometimes not added to client pages when a sitelink is added on a repo

2020-03-04 Thread Ladsgroup
Ladsgroup added a comment. In T233520#5941300 , @Lydia_Pintscher wrote: > Can someone confirm this is working for you now please? It will go live tomorrow evening. Then it can be checked. TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T233520: page_props wikibase_item is sometimes not added to client pages when a sitelink is added on a repo

2020-03-04 Thread Lydia_Pintscher
Lydia_Pintscher added a comment. Can someone confirm this is working for you now please? TASK DETAIL https://phabricator.wikimedia.org/T233520 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Lydia_Pintscher Cc: CCicalese_WMF, Anomie,

[Wikidata-bugs] [Maniphest] [Commented On] T233520: page_props wikibase_item is sometimes not added to client pages when a sitelink is added on a repo

2020-03-02 Thread gerritbot
gerritbot added a comment. Change 574868 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Remove rootJobTimestamp from refreshLinks jobs in client https://gerrit.wikimedia.org/r/574868 TASK DETAIL https://phabricator.wikimedia.org/T233520 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T233520: page_props wikibase_item is sometimes not added to client pages when a sitelink is added on a repo

2020-02-25 Thread gerritbot
gerritbot added a comment. Change 574868 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup): [mediawiki/extensions/Wikibase@master] Remove rootJobTimestamp from refreshLinks jobs in client https://gerrit.wikimedia.org/r/574868 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T233520: page_props wikibase_item is sometimes not added to client pages when a sitelink is added on a repo

2020-02-25 Thread daniel
daniel added a comment. In T233520#5897446 , @Ladsgroup wrote: > This already happens (changing page_touched) through `HTMLCacheUpdateJob` and that's one of the reasons the problem exists, because the try_to_get_cached_parser_output

[Wikidata-bugs] [Maniphest] [Commented On] T233520: page_props wikibase_item is sometimes not added to client pages when a sitelink is added on a repo

2020-02-20 Thread Addshore
Addshore added a comment. Moving to waiting, waiting on core platform again now I guess TASK DETAIL https://phabricator.wikimedia.org/T233520 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ladsgroup, Addshore Cc: CCicalese_WMF, Anomie,

[Wikidata-bugs] [Maniphest] [Commented On] T233520: page_props wikibase_item is sometimes not added to client pages when a sitelink is added on a repo

2020-02-19 Thread Ladsgroup
Ladsgroup added a comment. In T233520#5895999 , @Addshore wrote: > Updating page touched would also work? > > In T233520#5855858 , @daniel wrote: > >> In T233520#5855751

[Wikidata-bugs] [Maniphest] [Commented On] T233520: page_props wikibase_item is sometimes not added to client pages when a sitelink is added on a repo

2020-02-18 Thread Addshore
Addshore added a comment. Updating page touched would also work? In T233520#5855858 , @daniel wrote: > In T233520#5855751 , @Addshore wrote: > >> - updating page_touched would

[Wikidata-bugs] [Maniphest] [Commented On] T233520: page_props wikibase_item is sometimes not added to client pages when a sitelink is added on a repo

2020-02-06 Thread daniel
daniel added a comment. In T233520#5855751 , @Addshore wrote: > - updating page_touched would probably trigger a reparse of the page (and currently that doesn't happen for the case described) In practical terms, WikiPageUpdater

[Wikidata-bugs] [Maniphest] [Commented On] T233520: page_props wikibase_item is sometimes not added to client pages when a sitelink is added on a repo

2020-02-06 Thread Addshore
Addshore added a comment. So we had a call and determined that: - We really don't know how long this has been broken for - updating page_touched would probably trigger a reparse of the page (and currently that doesn't happen for the case described) Other notes: - Should check

[Wikidata-bugs] [Maniphest] [Commented On] T233520: page_props wikibase_item is sometimes not added to client pages when a sitelink is added on a repo

2020-01-28 Thread Addshore
Addshore added a comment. In T233520#5835442 , @daniel wrote: > @Addshore Investigating this requires a dev setup with Wikibase. I don't have one handy... I think it would be best if we could spend an hour or so investigating this

[Wikidata-bugs] [Maniphest] [Commented On] T233520: page_props wikibase_item is sometimes not added to client pages when a sitelink is added on a repo

2020-01-27 Thread daniel
daniel added a comment. @Addshore Investigating this requires a dev setup with Wikibase. I don't have one handy... I think it would be best if we could spend an hour or so investigating this together. Maybe via hangout next week? Send me an invite... TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T233520: page_props wikibase_item is sometimes not added to client pages when a sitelink is added on a repo

2020-01-27 Thread CCicalese_WMF
CCicalese_WMF added a comment. Thanks for the reminder. I will check on this. TASK DETAIL https://phabricator.wikimedia.org/T233520 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore, CCicalese_WMF Cc: CCicalese_WMF, Anomie, Petar.petkovic,

[Wikidata-bugs] [Maniphest] [Commented On] T233520: page_props wikibase_item is sometimes not added to client pages when a sitelink is added on a repo

2020-01-22 Thread Tacsipacsi
Tacsipacsi added a comment. I’ve just read a (ca. three months old) report mentioning that Yair rand’s WikidataInfo.js tells after connecting that no Wikidata item found. This script queries directly the Wikidata API, so the bug

[Wikidata-bugs] [Maniphest] [Commented On] T233520: page_props wikibase_item is sometimes not added to client pages when a sitelink is added on a repo

2020-01-21 Thread Addshore
Addshore added a comment. *poke* @Anomie and @aaron to take a look at this. TASK DETAIL https://phabricator.wikimedia.org/T233520 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore Cc: Anomie, Petar.petkovic, Zoranzoki21, Tacsipacsi,

[Wikidata-bugs] [Maniphest] [Commented On] T233520: page_props wikibase_item is sometimes not added to client pages when a sitelink is added on a repo

2020-01-15 Thread Mike_Peel
Mike_Peel added a comment. Thank you, @Addshore, for investigating this issue! TASK DETAIL https://phabricator.wikimedia.org/T233520 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore, Mike_Peel Cc: Petar.petkovic, Zoranzoki21, Tacsipacsi,

[Wikidata-bugs] [Maniphest] [Commented On] T233520: page_props wikibase_item is sometimes not added to client pages when a sitelink is added on a repo

2020-01-15 Thread Addshore
Addshore added a comment. So, after a little more investigation and reproduction on testwikipedia nd test wikidata - Create a page on wikipedia that includes some data data from a statement on wikidata item - The wikipedia page will be parsed and rendered with the data from wikidata

[Wikidata-bugs] [Maniphest] [Commented On] T233520: page_props wikibase_item is sometimes not added to client pages when a sitelink is added on a repo

2020-01-15 Thread daniel
daniel added a comment. I haven't done a full analysis, but I'm wondering why this is using the ContentAlterParserOutput hook, instead of RevisionDataUpdates? Conceptually, ContentAlterParserOutput is a filter-style hook that shouldn't have side effects. RevisionDataUpdates is specifically