[Wikidata-bugs] [Maniphest] [Commented On] T239902: Finish Styling Popper

gerritbot added a comment. Change 556229 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)): [mediawiki/extensions/Wikibase@master] Add styles to tainted reference popper https://gerrit.wikimedia.org/r/556229 TASK DETAIL https://phabricator.wi

[Wikidata-bugs] [Maniphest] [Commented On] T239902: Finish Styling Popper

gerritbot added a comment. Change 556229 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Add styles to tainted reference popper https://gerrit.wikimedia.org/r/556229 TASK DETAIL https://phabricator.wikimedia.org/T239902 EMAIL PREFERENCES https://phabricator.wikime

[Wikidata-bugs] [Maniphest] [Commented On] T239902: Finish Styling Popper

gerritbot added a comment. Change 556409 had a related patch set uploaded (by Addshore; owner: Rosalie Perside (WMDE)): [mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.10] Add styles to tainted reference popper https://gerrit.wikimedia.org/r/556409 TASK DETAIL https://phabricator.wiki

[Wikidata-bugs] [Maniphest] [Commented On] T239902: Finish Styling Popper

Sarai-WMDE added a comment. Hi there! I cannot properly inspect the popper in Beta, but I can notice it needs just a couple adjustment to follow the specs. Moving this task to "To Do" as indicated by @Lydia_Pintscher Component in beta: F31473457: popper_beta.png

[Wikidata-bugs] [Maniphest] [Commented On] T239902: Finish Styling Popper

gerritbot added a comment. Change 556640 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)): [mediawiki/extensions/Wikibase@master] Fix tainted references popper title https://gerrit.wikimedia.org/r/556640 TASK DETAIL https://phabricator.wikim

[Wikidata-bugs] [Maniphest] [Commented On] T239902: Finish Styling Popper

gerritbot added a comment. Change 556409 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.10] Add styles to tainted reference popper https://gerrit.wikimedia.org/r/556409 TASK DETAIL https://phabricator.wikimedia.org/T239902 EMAIL PREFERENCES https://phabri

[Wikidata-bugs] [Maniphest] [Commented On] T239902: Finish Styling Popper

gerritbot added a comment. Change 556640 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Fix tainted references popper title https://gerrit.wikimedia.org/r/556640 TASK DETAIL https://phabricator.wikimedia.org/T239902 EMAIL PREFERENCES https://phabricator.wikimedia

[Wikidata-bugs] [Maniphest] [Commented On] T239902: Finish Styling Popper

gerritbot added a comment. Change 556663 had a related patch set uploaded (by Tarrow; owner: Tarrow): [mediawiki/extensions/Wikibase@master] TR: Adjust placing and spacing of feedback link https://gerrit.wikimedia.org/r/556663 TASK DETAIL https://phabricator.wikimedia.org/T239902 EM

[Wikidata-bugs] [Maniphest] [Commented On] T239902: Finish Styling Popper

gerritbot added a comment. Change 556663 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] TR: Adjust placing and spacing of feedback link https://gerrit.wikimedia.org/r/556663 TASK DETAIL https://phabricator.wikimedia.org/T239902 EMAIL PREFERENCES https://phabrica

[Wikidata-bugs] [Maniphest] [Commented On] T239902: Finish Styling Popper

gerritbot added a comment. Change 556710 had a related patch set uploaded (by Tarrow; owner: Tarrow): [mediawiki/extensions/Wikibase@master] TR: Fix line heights https://gerrit.wikimedia.org/r/556710 TASK DETAIL https://phabricator.wikimedia.org/T239902 EMAIL PREFERENCES https://ph

[Wikidata-bugs] [Maniphest] [Commented On] T239902: Finish Styling Popper

gerritbot added a comment. Change 556714 had a related patch set uploaded (by Addshore; owner: Rosalie Perside (WMDE)): [mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.10] Fix tainted references popper title https://gerrit.wikimedia.org/r/556714 TASK DETAIL https://phabricator.wikimed

[Wikidata-bugs] [Maniphest] [Commented On] T239902: Finish Styling Popper

gerritbot added a comment. Change 556717 had a related patch set uploaded (by Addshore; owner: Tarrow): [mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.10] TR: Fix line heights https://gerrit.wikimedia.org/r/556717 TASK DETAIL https://phabricator.wikimedia.org/T239902 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] [Commented On] T239902: Finish Styling Popper

gerritbot added a comment. Change 556715 had a related patch set uploaded (by Addshore; owner: Tarrow): [mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.10] TR: Adjust placing and spacing of feedback link https://gerrit.wikimedia.org/r/556715 TASK DETAIL https://phabricator.wikimedia.or

[Wikidata-bugs] [Maniphest] [Commented On] T239902: Finish Styling Popper

gerritbot added a comment. Change 556710 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] TR: Fix line heights and close icon size https://gerrit.wikimedia.org/r/556710 TASK DETAIL https://phabricator.wikimedia.org/T239902 EMAIL PREFERENCES https://phabricator.wik

[Wikidata-bugs] [Maniphest] [Commented On] T239902: Finish Styling Popper

gerritbot added a comment. Change 557845 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)): [mediawiki/extensions/Wikibase@master] TR: Fix line Space between help link and popper text https://gerrit.wikimedia.org/r/557845 TASK DETAIL https:/

[Wikidata-bugs] [Maniphest] [Commented On] T239902: Finish Styling Popper

gerritbot added a comment. Change 556714 abandoned by Addshore: Fix tainted references popper title Reason: Plan is no longer to backport these per mattermost discussion. https://gerrit.wikimedia.org/r/556714 TASK DETAIL https://phabricator.wikimedia.org/T239902 EMAIL PREFEREN

[Wikidata-bugs] [Maniphest] [Commented On] T239902: Finish Styling Popper

gerritbot added a comment. Change 556715 abandoned by Addshore: TR: Adjust placing and spacing of feedback link Reason: Plan is no longer to backport these per mattermost discussion. https://gerrit.wikimedia.org/r/556715 TASK DETAIL https://phabricator.wikimedia.org/T239902 EM

[Wikidata-bugs] [Maniphest] [Commented On] T239902: Finish Styling Popper

gerritbot added a comment. Change 556717 abandoned by Addshore: TR: Fix line heights Reason: Plan is no longer to backport these per mattermost discussion. https://gerrit.wikimedia.org/r/556717 TASK DETAIL https://phabricator.wikimedia.org/T239902 EMAIL PREFERENCES https://p

[Wikidata-bugs] [Maniphest] [Commented On] T239902: Finish Styling Popper

gerritbot added a comment. Change 557845 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] TR: Fix line Space between help link and popper text https://gerrit.wikimedia.org/r/557845 TASK DETAIL https://phabricator.wikimedia.org/T239902 EMAIL PREFERENCES https://pha

[Wikidata-bugs] [Maniphest] [Commented On] T239902: Finish Styling Popper

gerritbot added a comment. Change 558065 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)): [mediawiki/extensions/Wikibase@master] TR:Change to for the popper close button https://gerrit.wikimedia.org/r/558065 TASK DETAIL https://phabricat

[Wikidata-bugs] [Maniphest] [Commented On] T239902: Finish Styling Popper

gerritbot added a comment. Change 558065 abandoned by Rosalie Perside (WMDE): TR:Change to for the popper close button Reason: this change I85d2ba1f7a32f04b4039503d21cfc1a839df89c6 will have the html tag change in it https://gerrit.wikimedia.org/r/558065 TASK DETAIL https://

[Wikidata-bugs] [Maniphest] [Commented On] T239902: Finish Styling Popper

gerritbot added a comment. Change 558481 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)): [mediawiki/extensions/Wikibase@master] Remove on focus property on close button https://gerrit.wikimedia.org/r/558481 TASK DETAIL https://phabricator

[Wikidata-bugs] [Maniphest] [Commented On] T239902: Finish Styling Popper

gerritbot added a comment. Change 558560 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)): [mediawiki/extensions/Wikibase@master] TR: Add close on ESC key press and finish styling the popper close button https://gerrit.wikimedia.org/r/558560

[Wikidata-bugs] [Maniphest] [Commented On] T239902: Finish Styling Popper

gerritbot added a comment. Change 558560 abandoned by Rosalie Perside (WMDE): TR: Add close on ESC key press and finish styling the popper close button https://gerrit.wikimedia.org/r/558560 TASK DETAIL https://phabricator.wikimedia.org/T239902 EMAIL PREFERENCES https://phabricator.

[Wikidata-bugs] [Maniphest] [Commented On] T239902: Finish Styling Popper

gerritbot added a comment. Change 558570 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)): [mediawiki/extensions/Wikibase@master] TR: Add close on ESC key press and finish styling the popper close button https://gerrit.wikimedia.org/r/558570

[Wikidata-bugs] [Maniphest] [Commented On] T239902: Finish Styling Popper

gerritbot added a comment. Change 558481 abandoned by Rosalie Perside (WMDE): Remove on focus property on close button https://gerrit.wikimedia.org/r/558481 TASK DETAIL https://phabricator.wikimedia.org/T239902 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emai

[Wikidata-bugs] [Maniphest] [Commented On] T239902: Finish Styling Popper

gerritbot added a comment. Change 558570 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] TR: Add close on ESC key press and finish styling the popper close button https://gerrit.wikimedia.org/r/558570 TASK DETAIL https://phabricator.wikimedia.org/T239902 EMAIL PREF

[Wikidata-bugs] [Maniphest] [Commented On] T239902: Finish Styling Popper

gerritbot added a comment. Change 559454 had a related patch set uploaded (by Tarrow; owner: Tarrow): [mediawiki/extensions/Wikibase@master] TR: Adjust style again https://gerrit.wikimedia.org/r/559454 TASK DETAIL https://phabricator.wikimedia.org/T239902 EMAIL PREFERENCES https://

[Wikidata-bugs] [Maniphest] [Commented On] T239902: Finish Styling Popper

Tarrow added a comment. Put up one more which hopefully gets us bang on the spec apart form these odd artefacts (a little tiny vertical line by the help link) that I don't understand. If anyone has any idea then I'd be happy to know about it: F31486469: image.png

[Wikidata-bugs] [Maniphest] [Commented On] T239902: Finish Styling Popper

gerritbot added a comment. Change 559454 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] TR: Adjust style again https://gerrit.wikimedia.org/r/559454 TASK DETAIL https://phabricator.wikimedia.org/T239902 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings