[Wikidata-bugs] [Maniphest] [Commented On] T245396: SimpleCacheWithBagOStuff shouldnt be so easy to use bad keys with

Addshore added a comment. The gerrit patch above fixes the error described in T245396 and will be deployed with .30 this week. TASK DETAIL https://phabricator.wikimedia.org/T245396 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/p

[Wikidata-bugs] [Maniphest] [Commented On] T245396: SimpleCacheWithBagOStuff shouldnt be so easy to use bad keys with

gerritbot added a comment. Change 592304 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Remove bad assertions for keys in SimpleCacheWithBagOStuff https://gerrit.wikimedia.org/r/592304 TASK DETAIL https://phabricator.wikimedia.org/T245396 EMAIL PREFERENCES https

[Wikidata-bugs] [Maniphest] [Commented On] T245396: SimpleCacheWithBagOStuff shouldnt be so easy to use bad keys with

gerritbot added a comment. Change 592304 had a related patch set uploaded (by Addshore; owner: Addshore): [mediawiki/extensions/Wikibase@master] Remove bad assertions for keys in SimpleCacheWithBagOStuff https://gerrit.wikimedia.org/r/592304 TASK DETAIL https://phabricator.wikimedia.

[Wikidata-bugs] [Maniphest] [Commented On] T245396: SimpleCacheWithBagOStuff shouldnt be so easy to use bad keys with

Addshore added a comment. There is still an issue with this as identified in T246207#6078825 and T246207#6078826 In T246207#6078826 ,

[Wikidata-bugs] [Maniphest] [Commented On] T245396: SimpleCacheWithBagOStuff shouldnt be so easy to use bad keys with

gerritbot added a comment. Change 583199 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Call makeKey when sending the key to the internal cache in SimpleCacheWithBagOStuff https://gerrit.wikimedia.org/r/583199 TASK DETAIL https://phabricator.wikimedia.org/T245396

[Wikidata-bugs] [Maniphest] [Commented On] T245396: SimpleCacheWithBagOStuff shouldnt be so easy to use bad keys with

gerritbot added a comment. Change 583199 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup): [mediawiki/extensions/Wikibase@master] Call makeKey when sending the key to the internal cache in SimpleCacheWithBagOStuff https://gerrit.wikimedia.org/r/583199 TASK DETAIL ht

[Wikidata-bugs] [Maniphest] [Commented On] T245396: SimpleCacheWithBagOStuff shouldnt be so easy to use bad keys with

Krinkle added a comment. Yes, all keys passed to get/set must come from makeKey or makeGlobalKey from the same BagOStuff class. Where to call that depends on whether you intent to expose a general cache interface or one that has a finegrained purpose. Two examples. The generic one r

[Wikidata-bugs] [Maniphest] [Commented On] T245396: SimpleCacheWithBagOStuff shouldnt be so easy to use bad keys with

Tarrow added a comment. Thanks for those thoughts! So in your opinion it would be good if SimpleCacheWithBagOStuff: - automatically used makeKey - helped build more conventional cache keys Can you point me at the canonical naming scheme? I looked in https://www.mediawiki.org/w

[Wikidata-bugs] [Maniphest] [Commented On] T245396: SimpleCacheWithBagOStuff shouldnt be so easy to use bad keys with

Krinkle added a comment. @Tarrow I'm looking at the SimpleCacheWithBagOStuff source, and not only is it not proxying makeKey - it doesn't even have a makeKey or similar method from what I can see. How is it currently supposed to be used? I tried to find a usage example, and the first one

[Wikidata-bugs] [Maniphest] [Commented On] T245396: SimpleCacheWithBagOStuff shouldnt be so easy to use bad keys with

Jdforrester-WMF added a comment. New handful of errors in prod: `class@anonymous /srv/mediawiki/php-1.35.0-wmf.20/extensions/Wikibase/lib/includes/SimpleCacheWithBagOStuff.php0x7f9378c5e02f wmf.20 e/W/l/i/SimpleCacheWithBagOStuff.php:271 Cache key contains characters that are not al