[Wikidata-bugs] [Maniphest] [Commented On] T252489: Wikibase Lexeme test failures

2020-05-12 Thread gerritbot
gerritbot added a comment. Change 595884 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Remove unused wikibase global from more tests https://gerrit.wikimedia.org/r/595884 TASK DETAIL https://phabricator.wikimedia.org/T252489 EMAIL PREFERENCES https://phab

[Wikidata-bugs] [Maniphest] [Commented On] T252489: Wikibase Lexeme test failures

2020-05-12 Thread gerritbot
gerritbot added a comment. Change 595882 **merged** by jenkins-bot: [mediawiki/extensions/WikibaseLexeme@master] Remove unused reference to wikibase global in test https://gerrit.wikimedia.org/r/595882 TASK DETAIL https://phabricator.wikimedia.org/T252489 EMAIL PREFERENCES https:/

[Wikidata-bugs] [Maniphest] [Commented On] T252489: Wikibase Lexeme test failures

2020-05-12 Thread gerritbot
gerritbot added a comment. Change 595884 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseLexeme@master] Remove unused wikibase global from more tests https://gerrit.wikimedia.org/r/595884 TASK DETAIL http

[Wikidata-bugs] [Maniphest] [Commented On] T252489: Wikibase Lexeme test failures

2020-05-12 Thread gerritbot
gerritbot added a comment. Change 595882 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)): [mediawiki/extensions/WikibaseLexeme@master] Remove unused reference to wikibase global in test https://gerrit.wikimedia.org/r/595882 TASK DETAIL

[Wikidata-bugs] [Maniphest] [Commented On] T252489: Wikibase Lexeme test failures

2020-05-12 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. Hm, it looks like the `WikibaseLexeme.tests.ItemLookup` ResourceLoader module (see `src/WikibaseLexemeHooks.php`) doesn’t declare any dependencies, but still accesses the `wikibase` global. But TBH I’m not sure why it does that? It doesn’t seem to use

[Wikidata-bugs] [Maniphest] [Commented On] T252489: Wikibase Lexeme test failures

2020-05-12 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment. Doesn’t seem to happen all the time, a recheck on that change was successful. No idea yet how common the error is. TASK DETAIL https://phabricator.wikimedia.org/T252489 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailprefere