[Wikidata-bugs] [Maniphest] [Commented On] T254525: Don't use internal FallbackTemplate inside code

gerritbot added a comment. Change 602772 **merged** by jenkins-bot: [mediawiki/extensions/Wikibase@master] Don't use FallbackTemplate inside tests https://gerrit.wikimedia.org/r/602772 TASK DETAIL https://phabricator.wikimedia.org/T254525 EMAIL PREFERENCES https://phabricator.wikim

[Wikidata-bugs] [Maniphest] [Commented On] T254525: Don't use internal FallbackTemplate inside code

Jdlrobson added a comment. CookieWarning is not deployed anywhere on Wikimedia from what I can see so I don't think that should block the core change. TASK DETAIL https://phabricator.wikimedia.org/T254525 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences

[Wikidata-bugs] [Maniphest] [Commented On] T254525: Don't use internal FallbackTemplate inside code

gerritbot added a comment. Change 602772 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson): [mediawiki/extensions/Wikibase@master] Don't use FallbackTemplate inside tests https://gerrit.wikimedia.org/r/602772 TASK DETAIL https://phabricator.wikimedia.org/T254525 EMAI

[Wikidata-bugs] [Maniphest] [Commented On] T254525: Don't use internal FallbackTemplate inside code

Krinkle added a comment. They were likely picked because BaseTemplate is abstract so SkinFallbackTemplate was the only somewhat neutral non-abstract implementation in core to pick. Should straight-forward to replace by direct use of BaseTemplate with `createMock()`. TASK DETAIL https://ph