[Wikidata-bugs] [Maniphest] [Commented On] T256855: Create visalization for line height

Tonina_Zhelyazkova_WMDE added a comment. In T256855#6293409 , @Pablo-WMDE wrote: > @Sarai-WMDE > > I tried to incorporate the new decision into https://github.com/wmde/wikit/pull/60 - please verify visually. > > Also created http

[Wikidata-bugs] [Maniphest] [Commented On] T256855: Create visalization for line height

Pablo-WMDE added a comment. @Sarai-WMDE I tried to incorporate the new decision into https://github.com/wmde/wikit/pull/60 - please verify visually. Also created https://github.com/wmde/wikit/pull/68 which shows the idea as discussed in the meeting, demoing each line height at 3 fon

[Wikidata-bugs] [Maniphest] [Commented On] T256855: Create visalization for line height

Pablo-WMDE added a comment. I wrote down what was said during a call of 3 people (= messenger). I don't know why the requirement was changed again despite the explanation (implying it was intentional). During that conversation it was also mentioned that a more useful way of illustrating

[Wikidata-bugs] [Maniphest] [Commented On] T256855: Create visalization for line height

Tonina_Zhelyazkova_WMDE added a comment. In T256855#6292663 , @Pablo-WMDE wrote: > In a comment on the PR > >> we can go back to using 16px: > > and again during a co

[Wikidata-bugs] [Maniphest] [Commented On] T256855: Create visalization for line height

Pablo-WMDE added a comment. In a comment on the PR > we can go back to using 16px: and again during a conversation after the daily, it was decided to use the same font size, 16px, to present all line heights. TASK DETAI

[Wikidata-bugs] [Maniphest] [Commented On] T256855: Create visalization for line height

Pablo-WMDE added a comment. @Sarai-WMDE I have a question about > apply the following sizes to each specimen (none: 16px, 1.25: 18px, 1.5: 16px, 1.6: 14px) We are changing the font //size// depending on the token value (line-height), thereby changing two variables at once and making

[Wikidata-bugs] [Maniphest] [Commented On] T256855: Create visalization for line height

Sarai-WMDE added a comment. Checked! Looks good. Ready to move to done. TASK DETAIL https://phabricator.wikimedia.org/T256855 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tonina_Zhelyazkova_WMDE, Sarai-WMDE Cc: Pablo-WMDE, Aklapper, Sarai-WMDE,

[Wikidata-bugs] [Maniphest] [Commented On] T256855: Create visalization for line height

Pablo-WMDE added a comment. @Sarai-WMDE Kindly take a look at the storybook linked in the PR . TASK DETAIL https://phabricator.wikimedia.org/T256855 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tonina_Zhe

[Wikidata-bugs] [Maniphest] [Commented On] T256855: Create visalization for line height

Tonina_Zhelyazkova_WMDE added a comment. In T256855#6277459 , @Sarai-WMDE wrote: > Leaving here a couple of improvements: > > 1. Make the font size of the value column 14px. > 2. It may make sense to use typeset here too (like in th

[Wikidata-bugs] [Maniphest] [Commented On] T256855: Create visalization for line height

Sarai-WMDE added a comment. Leaving here a couple of improvements: 1. Make the font size of the value column 14px. 2. It may make sense to use typeset here too (like in the rest of the font pages) rather than the blue background. If it does, then I would apply the following sizes to ea

[Wikidata-bugs] [Maniphest] [Commented On] T256855: Create visalization for line height

Pablo-WMDE added a comment. @Sarai-WMDE https://wmde.github.io/wikit/?path=/docs/design-tokens-font-line-height--page TASK DETAIL https://phabricator.wikimedia.org/T256855 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Pablo-WMDE,

[Wikidata-bugs] [Maniphest] [Commented On] T256855: Create visalization for line height

Pablo-WMDE added a comment. https://github.com/wmde/wikit/pull/46 TASK DETAIL https://phabricator.wikimedia.org/T256855 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Pablo-WMDE, Aklapper, Sarai-WMDE, Jakob_WMDE, Tonina_Zhelyazkova