[Wikidata-bugs] [Maniphest] [Commented On] T257057: Create visalization for borders

Sarai-WMDE added a comment. Looking good 😄 ✅ TASK DETAIL https://phabricator.wikimedia.org/T257057 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tonina_Zhelyazkova_WMDE, Sarai-WMDE Cc: Aklapper, Sarai-WMDE, Jakob_WMDE, Tonina_Zhelyazkova_WMDE,

[Wikidata-bugs] [Maniphest] [Commented On] T257057: Create visalization for borders

Pablo-WMDE added a comment. @Sarai-WMDE Kindly take a look at the storybook linked in https://github.com/wmde/wikit/pull/61. TASK DETAIL https://phabricator.wikimedia.org/T257057 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Tonina_Zhelyazkova_

[Wikidata-bugs] [Maniphest] [Commented On] T257057: Create visalization for borders

Tonina_Zhelyazkova_WMDE added a comment. In T257057#6285500 , @Sarai-WMDE wrote: > Sorry, I'm only reading these comments now. My inbox is swamped. > >> would that be for border colors only, or for all presentations of colors? > >

[Wikidata-bugs] [Maniphest] [Commented On] T257057: Create visalization for borders

Sarai-WMDE added a comment. Sorry, I'm only reading these comments now. My inbox is swamped. > would that be for border colors only, or for all presentations of colors? Borders only. It visually supports the tokens semantics > does "rather than to the background of the presenter"

[Wikidata-bugs] [Maniphest] [Commented On] T257057: Create visalization for borders

Pablo-WMDE added a comment. > I guess having a white border with white background rectangle is a problem. We don't have that in the tokens so far and I'd be curious to hear if that's even possible (from a design perspective). I was referring to the situation as seen in https://5efdb3b5f

[Wikidata-bugs] [Maniphest] [Commented On] T257057: Create visalization for borders

Tonina_Zhelyazkova_WMDE added a comment. In T257057#6285338 , @Pablo-WMDE wrote: > @Sarai-WMDE > >> Adding a suggestion here: we could improve this visualization by applying every border color to the border rather than to the backgro

[Wikidata-bugs] [Maniphest] [Commented On] T257057: Create visalization for borders

Pablo-WMDE added a comment. @Sarai-WMDE > Adding a suggestion here: we could improve this visualization by applying every border color to the border rather than to the background of the presenter. To make sure the border color is perceivable, that border should be 2px. Few question

[Wikidata-bugs] [Maniphest] [Commented On] T257057: Create visalization for borders

Sarai-WMDE added a comment. Adding a suggestion here: we could improve this visualization by applying every border color to the border rather than to the background of the presenter. To make sure the border color is perceivable, that border should be 2px. TASK DETAIL https://phabricator.w

[Wikidata-bugs] [Maniphest] [Commented On] T257057: Create visalization for borders

Sarai-WMDE added a comment. Related to our upcoming discussion on how to display tokens with the two levels of granularity: Ideally, the Border page should contain two different sections: - (h2) Border style (which contains: //border style// (global tokens), and //border widths// a

[Wikidata-bugs] [Maniphest] [Commented On] T257057: Create visalization for borders

Pablo-WMDE added a comment. @Sarai-WMDE http://172.17.0.2:43149/?path=/docs/design-tokens-borders--page TASK DETAIL https://phabricator.wikimedia.org/T257057 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Aklapper, Sarai-WMDE, Jako

[Wikidata-bugs] [Maniphest] [Commented On] T257057: Create visalization for borders

Pablo-WMDE added a comment. https://github.com/wmde/wikit/pull/51 TASK DETAIL https://phabricator.wikimedia.org/T257057 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pablo-WMDE Cc: Aklapper, Sarai-WMDE, Jakob_WMDE, Tonina_Zhelyazkova_WMDE, Pablo