gerritbot added a comment.
Change 204811 merged by jenkins-bot:
Drop redundant sitelinks when merging items
https://gerrit.wikimedia.org/r/204811
TASK DETAIL
https://phabricator.wikimedia.org/T85347
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or
gerritbot added a subscriber: gerritbot.
gerritbot added a comment.
Change 204811 had a related patch set uploaded (by Addshore):
Drop redundant sitelinks when merging items
https://gerrit.wikimedia.org/r/204811
TASK DETAIL
https://phabricator.wikimedia.org/T85347
REPLY HANDLER ACTIONS
petr.matas added a comment.
You're right.
TASK DETAIL
https://phabricator.wikimedia.org/T85347
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
Addshore added a comment.
But this is a sort of broken state which breaks things.
There should only ever be one sitelink on one item (including redirects to that
site link), hence why the software doesn't allow you to add them in the first
place!
And that's why I don't see the issue with what I
petr.matas added a comment.
It can happen the following way:
- Create [[en:Bonnie Parker]], linked to a new item Q1
- Create [[en:Clyde Barrow]], linked to a new item Q2
- Create [[en:Bonnie and Clyde]], not linked to any item
- Merge [[en:Bonnie Parker]] and [[en:Clyde Barrow]] into [[en:Bonnie
Addshore added a comment.
But the case will still never be able to happen on Wikidata..?
TASK DETAIL
https://phabricator.wikimedia.org/T85347
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
Addshore added a comment.
The case you have just described should not / can not happen.
TASK DETAIL
https://phabricator.wikimedia.org/T85347
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL PREFERENCES
Multichill added a comment.
All sounds good! Should make it easier to clean up duplicates/Wikipedia article
merges.
TASK DETAIL
https://phabricator.wikimedia.org/T85347
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or !assign
username.
EMAIL
Addshore added a comment.
So the bit of code we would need to touch is this method
https://github.com/wikimedia/mediawiki-extensions-Wikibase/blob/master/repo/includes/ChangeOp/ChangeOpsMerge.php#L199
I guess it would be, If there are conflicts for a site then find the actual
final target of
petr.matas added a comment.
In https://phabricator.wikimedia.org/T85347#969150, @Addshore wrote:
I guess it would be, If there are conflicts for a site then find the actual
final target of both sitelinks (the one we are trying to add and the one
already there).
If both targets match then
Sjoerddebruin added a comment.
Would be great if this also works with the real duplicates (same sitelink on
two items), but I like the idea. :)
TASK DETAIL
https://phabricator.wikimedia.org/T85347
REPLY HANDLER ACTIONS
Reply to comment or attach files, or !close, !claim, !unsubscribe or
11 matches
Mail list logo